870282 - Searching by "Priority" is missing an "Isn't" operator

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[:aceman]

If searching messages by the Priority field, the available operators are "Is", "Is Lower than", "Is Higher than". There is no "Isn't" operator.

The use-case could be:
Search all messages where Priority isn't Normal. It is currently possible to simulate that via "(Priority, is higher than, Normal) OR (Priority, is lower than, Normal)", but that forces the OR operator on all other search terms in the same search (or filter).

So this operator needs to be added to:
nsMsgSearchTerm.cpp > nsMsgSearchTerm::MatchPriority

and:
mailnews/base/search/src/nsMsgImapSearch.cpp (in the lines like: "SetAvailable (nsMsgSearchAttrib::Priority, nsMsgSearchOp::Is, 1);") . It seems the UI picks it up from there.

Comment 1

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch

Sir,

I have tried to make the changes as per the description.

Comment 2

[Kent James (:rkent)]

Could you add a test for this new attribute in mailnews/base/test/unit/test_search.js?

Comment 3

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v2

Sir,

I have added the test.

Comment 4

[:aceman]

Comment on attachment 748229 [details] [diff] [review]
Patch v2

The change and the test works great! Thanks.

Comment 5

[Kent James (:rkent)]

Comment on attachment 748229 [details] [diff] [review]
Patch v2

Review of attachment 748229 [details] [diff] [review]:
-----------------------------------------------------------------

Overall, looks good and great job. Please just fix the one nit.

::: mailnews/base/test/unit/test_search.js
@@ +207,5 @@
>        customHeader: "withspace",
>        count: 1},
> +    
> +    //test for priority
> +    { testString: Components.interfaces.nsMsgPriority.lowest,

Nit: In xpcshell tests, standard abbreviations are predefined, and should be used. So please change these five instances of Components.interfaces. to Ci.

Comment 6

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v2 (revised)

Comment 7

[Suyash Agarwal (:sshagarwal)]

Sir,
Thanks for your review and feedback.
I have made the changes.
Carrying over review from rkent.

Comment 8

[:aceman]

Comment on attachment 749207 [details] [diff] [review]
Patch v2 (revised)

Yes, that's it.

Comment 9

[:aceman]

Congratulations to your first user visible change in TB and Seamonkey:)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/e232ca630f82