Closed
Bug 870306
Opened 11 years ago
Closed 11 years ago
Includes should go under /usr/include/mozjs-x.y
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
4.69 KB,
patch
|
sstangl
:
review+
Waldo
:
review+
|
Details | Diff | Splinter Review |
MODULE is not really useful per se, but it is used to determine, for example, the pkg-config file name and such. Which means that with the current value, its name is either js.pc or js-x.y.pc. IMHO js a too generic name to claim for pkg-config, /usr/include, etc. It should be smjs or mozjs.
|
Assignee | |
Comment 1•11 years ago
|
||
Mmm so in fact, the pkg-config file *is* named mozjs-x.y.pc, which is even more inconsistent with js-config and /usr/include/js-x.y. These are the ones that need to change.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Let's already take care of /usr/include. js-config should probably die.
Summary: MODULE in js/src/moz.build should be mozjs instead of js → Includes should go under /usr/include/mozjs-x.y
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #747347 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
|
|
Assignee | |
Comment 4•11 years ago
|
||
In fact, with this change we don't even need to alter MODULE anymore.
Attachment #747354 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #747347 -
Attachment is obsolete: true
Attachment #747347 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 747354 [details] [diff] [review] Put includes under /usr/include/mozjs-x.y instead of /usr/include/js-x.y on make install Forget it, this is missing some things.
Attachment #747354 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Attachment #747389 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #747354 -
Attachment is obsolete: true
|
||
Comment 7•11 years ago
|
||
Comment on attachment 747389 [details] [diff] [review] Put includes under /usr/include/mozjs-x.y instead of /usr/include/js-x.y on make install Review of attachment 747389 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but forwarding to Sean mostly so more people are aware of the state of affairs on this...
Attachment #747389 -
Flags: review?(sstangl)
Attachment #747389 -
Flags: review?(jwalden+bmo)
Attachment #747389 -
Flags: review+
|
||
Updated•11 years ago
|
Attachment #747389 -
Flags: review?(sstangl) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/668d1525ef29
|
||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/668d1525ef29
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•