870728 - The Geolocation prompt should not offer action in PB mode if the action remembers permission for more than a session.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Philip Chee]

Spun off from Bug 870413 Comment 3:
>> +            if (site && !this.usePrivateBrowsing) {
> Eek. Should backport this I guess...

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix.

I've split this patch off from Bug 870413 so that we can land this on all branches including comm-release.

Comment 2

[Philip Chee]

a-beta=Callek a=CLOSED TREE 
Pushed to comm-beta:
http://hg.mozilla.org/releases/comm-beta/rev/fb4f91ec5302

Comment 3

[Philip Chee]

Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/39546ca48c28

Comment 4

[Philip Chee]

Comment on attachment 747893 [details] [diff] [review]
Patch v1.0 Proposed fix.

Firefox Bug 496595 (Privacy leak in "remember for this site" permission of geolocation - persists outside of private browsing) landed on Firefox 3.6a1

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Privacy leak in "remember for this site" permission of geolocation

User impact if declined: Privacy leak in "remember for this site" permission of geolocation. Since this patch has already landed on SM 2.18 and SM2.21 we should ensure that it also lands on 2.19 and 2.20.

Testing completed (on m-c, etc.): Has been running for a while on my self build. The firefox version of this bug has been running since Fx3.6a1.

Risk to taking this patch (and alternatives if risky):
Risk is low.

String or IDL/UUID changes made by this patch:

Comment 5

[Philip Chee]

Pushed to comm-beta (SeaMonkey 2.19b)
https://hg.mozilla.org/releases/comm-beta/rev/659a7205d5b9
Pushed to comm-aurora (SeaMonkey 2.20a)
https://hg.mozilla.org/releases/comm-aurora/rev/9cf36ae1f02a