Closed Bug 870982 Opened 11 years ago Closed 11 years ago

Refactor mediaGallery to allow for different page type make API responses

Categories

(Webmaker Graveyard :: webmaker.org, defect)

Product:
Webmaker Graveyard
Component:
webmaker.org
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jfong, Assigned: jfong)

Details

Attachments

(1 file)

https://github.com/mozilla/webmaker.org/pull/16
47 bytes, text/x-github-pull-request
Details | Review 
Just adjusting some stuff in mediaGallery.js so that it is more reusable
Ross, I'll be in MV next week so if it's r+ feel free to merge in for me - thanks!
Attachment #748183 - Flags: review?(ross)
Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/02e81abf68f4965cf35021a5d457cf49cd0e6292
refactor mediaGallery to support multiple pages; bug 870982

https://github.com/mozilla/webmaker.org/commit/f64b2aa792712f092058ff190824486c51cf0dce
Merge pull request #16 from ednapiranha/teach

refactor mediaGallery to support multiple pages; bug 870982
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 748183 [details] [review]
https://github.com/mozilla/webmaker.org/pull/16

I still get emails about needing a review on this :(
Attachment mime type: text/plain → text/x-github-pull-request
Attachment #748183 - Flags: review?(rossbruniges) → review+
Attachment #748183 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: