871126 - Defect - Welcome to Firefox tab displaying under "Tabs from Other Devices" despite being closed

Status: RESOLVED INVALID

(Firefox for Metro Graveyard :: Sync, defect, P4)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: "Welcome to Firefox" listed under "Tabs from Other Devices"

When you initially setup a "Sync" account using Firefox Desktop, the "Welcome to Firefox" tab will be synced and will always appear under "Tabs from Other Devices" in Firefox Metro. When you pair another Firefox Metro (so two machines), "Welcome to Firefox" will also appear under the second machine.

Steps to reproduce the issue:

1) Install the latest Nightly Firefox on Computer A
2) Setup a new "Sync" account using "Sync" under "Options" on Computer A with Firefox Desktop (don't close the two default tabs that are opened when you first launch Firefox Desktop)
3) Once you receive the "Setup Complete" Tab on Computer A, close Firefox Desktop
4) Open Firefox Metro on Computer A and you will notice "Tabs from Other Devices" will have "Welcome to Firefox" listed (See the screenshot attached)
5) Pair two Firefox Metro machines and you will notice both of them will now have "Welcome to Firefox" listed under "Tabs from Other Devices"
6) Close all the Firefox's opened on both Computer A and Computer B and then re-open Firefox Metro on both of them ("Welcome to Firefox" will still be listed after the sync is completed despite not being opened anywhere)

Current Behavior:

- "Welcome to Firefox" is being displayed under "Tabs from Other Devices" despite not being opened anywhere

Expected Behavior:

- There shouldn't be anything under "Tabs from Other Devices" as Firefox Desktop was closed and only the "awesome screen" is opened in Firefox Metro

Comment 1

[Allison Naaktgeboren :ally]

Kamil, when you file any sync bug, please include the logs! One can't debug sync without them! I also understand you've changed a bunch of the intervals on your builds?

Comment 2

[Kamil Jozwiak [:kjozwiak]]

Ally, I will start posting logs for any sync issues found from now on! I've attached two zip files with some logs in them, hopefully it has some useful information. Please let me know if there's something else that I can enable in about:config that will make it easier for you to debug this problem.

Computer A - This was the machine that was used to created the sync account right after the Firefox installation.

Computer B - This is the second machine that I paired with Computer A

I did change the intervals as it makes it easier to test. The default values are set really high making it very difficult to go through syncing tickets. Here are the intervals that I changed:

pref("services.sync.scheduler.singleDeviceInterval", 86400);
pref("services.sync.scheduler.idleInterval",         120);
pref("services.sync.scheduler.activeInterval",       60);
pref("services.sync.scheduler.immediateInterval",    90);
pref("services.sync.scheduler.idleTime",             60);

So basically, what happens is when you launch Firefox Desktop and create a "Sync" account (leaving all the default tabs opened right after an install), those default tabs will be synced into Firefox Metro and will never get cleared from "Tabs from Other Devices". If you pair more machines, it will also sync to those machines. In the end, you will get into a situation where the "Welcome to Firefox" website will be under "Tabs from Other Devices" on every single Firefox Metro machine even though the tab has been closed a long time ago.

Comment 3

[Kamil Jozwiak [:kjozwiak]]

Attachment: Computer A Logs (machine used to create Sync account)

Comment 4

[Kamil Jozwiak [:kjozwiak]]

Attachment: Machine that was paired with Computer A

Comment 5

[Richard Newman [:rnewman]]

Your STR don't describe a bug.

"Tabs from other computers" doesn't mean "the other computer has to be running". It's the last set of tabs open when the other device synced; the set that would be restored by Session Restore.

If you close tabs and sync that profile (Tools > Sync Now on desktop), you should see them disappear from TFOD on other devices once *those* devices sync.

If you're seeing some other behavior, with tabs sticking around if you do this:

* Close tab
* Sync
* Wait
* Quit
* Switch to other device/browser
* Sync
* Wait
* Check tabs

please reopen this bug.

Thanks!

Comment 6

[Kamil Jozwiak [:kjozwiak]]

Richard, thanks for clearing it up!. Makes a lot more sense now.