871278 - Bookmarks menu doesn't show any bookmarks after landing bug #867343

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Like it title. After backing out patches from bug #748894 in bug #867343 bookmarks aren't visible in Bookmarks menu (using Nightly button).
It works fine using  old Bookmarks menu (with ALT key) and in Bookmarks button in toolbar.

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bookmarks in Bookmark menu.png

Comment 2

[Alice0775 White]

An error appears in error Console when I click Bookmarks splitmenu.

Error: ReferenceError: BookmarksMenuButton is not defined
Source File: chrome://browser/content/browser.xul
Line: 1

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Yep, my bad - we didn't take into account https://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-appmenu.inc#222 when renaming BookmarksMenuButton BookmarkingUI.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 5

[Marco Bonardo [:mak]]

while there please also fix the 2 reportError in browser-places that reference BookmarksMenuButton

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Ugh, I pushed without fixing the reportErrors. :/ I'll file a follow-up.

Pushed to mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/01b4b6368014

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Filed follow-up bug 871594 for the reportErrors.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 748646 [details] [diff] [review]
Patch v1

[Approval Request Comment]

Bug caused by (feature/regressing bug #): Bug 867343

User impact if declined: Bookmarks menu in AppMenu will not list any bookmarks.

Testing completed (on m-c, etc.): Testing completed on m-c.

Risk to taking this patch (and alternatives if risky): Extremely low risk. We failed to change an instance of BookmarksMenuButton to BookmarkingUI.

String or IDL/UUID changes made by this patch: None.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01b4b6368014

Comment 10

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4583ecb8f831

Comment 11

[Manuela Muntean [Away]]

Verified as fixed with Firefox 23 beta 8, build ID: 20130722172257