Closed
Bug 871325
Opened 11 years ago
Closed 11 years ago
Bookmark star icon is tiny and duplicated on Retina MacBook Pro
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
VERIFIED
FIXED
Firefox 24
Tracking | Status | |
---|---|---|
firefox22 | --- | unaffected |
firefox23 | + | verified |
People
(Reporter: cpeterson, Assigned: mconley)
References
Details
(Keywords: regression)
Attachments
(2 files)
14.74 KB,
image/png
|
Details | |
718 bytes,
patch
|
mak
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Please see the attached screenshot. This regression first appeared in Nightly build 2013-05-12. I believe this is a regression from bug 867343.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Comment 1•11 years ago
|
||
@media (min-resolution: 2dppx) { #star-button { list-style-image: url("chrome://browser/skin/places/star-icons.png"); should be star-icons@2x.png
Assignee | ||
Comment 2•11 years ago
|
||
I don't have a Retina display to try this on, so flying blind here.
Attachment #748825 -
Flags: review?(mak77)
Comment 3•11 years ago
|
||
I can verify with DOMi on the retina, I should have done that originally...
Comment 4•11 years ago
|
||
Comment on attachment 748825 [details] [diff] [review] Patch v1 Review of attachment 748825 [details] [diff] [review]: ----------------------------------------------------------------- it works!
Attachment #748825 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Pushed to mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/a174d244334e
Assignee | ||
Updated•11 years ago
|
tracking-firefox23:
--- → ?
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 748825 [details] [diff] [review] Patch v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 867343 User impact if declined: OSX users with Retina displays will see a very strange grouping of icons where their star button used to be in their URL bar. Testing completed (on m-c, etc.): mak tested this on a Retina Macbook on m-c. Risk to taking this patch (and alternatives if risky): None - we simply failed to point some CSS at the right spritesheet. String or IDL/UUID changes made by this patch: None.
Attachment #748825 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #748825 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a174d244334e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c890c9a444f7
Updated•11 years ago
|
Matt, can you please verify this is fixed in Firefox 24 and 23 builds?
Keywords: verifyme
QA Contact: mwobensmith
Comment 10•11 years ago
|
||
Confirmed issue on m-c 2013-05-12. Confirmed fixed on FF23b4. Confirmed fixed on FF24 2013-07-11.
You need to log in
before you can comment on or make changes to this bug.
Description
•