87133 - Can't select last few lines of text in an Editor

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[kinmoz]

This bug has been driving me crazy for a while.

There seems to be a problem with selecting the last few lines of text in 
Composer (and it's variants) as well as textareas when the number of lines 
exceeds a multiple of 10 by 1 to 3 lines ... for example if you had 11 to 13 
lines, or 21 to 23 lines on the page you will not be able to click off the right 
edge of the last couple of lines to place the caret or extend the selection. You 
have to actually click *on* the text of the last few lines to place the caret or 
extend the selection.

A quick look in the debugger shows that 

I'll attatch a test case that demonstrates the problem.

In the test case, try clicking off the right side of the last line "Line 11". 
You'll notice that the caret get's placed on line 10 instead.

Comment 1

[kinmoz]

Attachment: Selection test case.

Comment 2

[rubydoo123]

this is a must fix bug -- not being able to select lines of text is not acceptable

Comment 3

[sujay]

adding QAHP...

Comment 4

[sujay]

cc: shrir.

Comment 5

[kinmoz]

Attachment: Patch that fixes the bug.

Comment 6

[kinmoz]

I just attatched the patch that fixes this bug.

The patch fixes a couple of problems that I saw in 
nsBlockFrame::GetClosestLine():

  1. Negative start value when clicking on the first line.
  2. Failure to include last few lines during search if
     Total number of lines was odd. (This bug)
  3. Removed unused define and var.
  4. Added comments.
  5. Renamed countLines to numLines.

Fix is relatively safe. Can I get an r= and sr=?

Comment 7

[Chris Waterson]

r=waterson

Comment 8

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 9

[mjudge]

Its GrrrreaT! looks good thanks kin! r=mjudge

Comment 10

[kinmoz]

Patch checked into MOZILLA_0_9_2_BRANCH:

    mozilla/layout/html/base/src/nsBlockFrame.cpp  revision 3.441.2.1

Patch checked into Trunk:

    mozilla/layout/html/base/src/nsBlockFrame.cpp  revision 3.442

Comment 11

[sujay]

Kin, can you verify if this is fixed on the branch?
thanks.

Comment 12

[sujay]

verified in 6/25 builds.

Comment 13

[kinmoz]

*** Bug 83650 has been marked as a duplicate of this bug. ***