87140 - Ok to blank psswd dlg does not prompt back the psswd dlg

Status: VERIFIED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Sheela Ravindran]

build ID: 2001061807win98
2001061808 linux, mac

Without typing any password and clicking ok on the password dialog should give 
the login failed error and should bring back the password dialog untill the user 
clicks on cancel button. 

steps:
-start mail application(use the profile that does not have password saved in 
password manager)
-when the password dlg comes up, don't enter anything in the field 
-click on ok button

Actual result:  Shows a dlg "Error getting mail password" with an ok button.
click on ok and the password dlg does not come up again untill clicked on get 
mssg button.

Expected result: shows the error dlg and ok to the button should bring back the 
password dialog untill connection is dropped or user hit cancel button. 

This problem is a regression bug. I found it when verifying bug 61171. It should 
 keep prompting the user for a new password if the previous password entered is 
blank, until the server does not close the connection on mozilla or user clicks 
on the cancel button. 
Checked on a pop account in 4.x and it does prompt the user back with the 
password dlg when the password entered is blank.

Comment 1

[Navin Gupta]

This is not a regression. It never worked in 6.x 

Comment 2

[Navin Gupta]

Attachment: proposed fix.

Comment 3

[Navin Gupta]

ok made it so that blank password also brings up the password dialog and 
also ensure that the window is always set in the url object. It is needed
to throw up alerts.

Comment 4

[scottputterman]

putting in 0.9.3

Comment 5

[Suresh]

r=suresh

Comment 6

[Scott MacGregor]

sr=mscott

Comment 7

[Navin Gupta]

fix checked in only on trunk. 

Comment 8

[Sheela Ravindran]

using trunk build-2001070206 on mac and windows. Ok to blank passwd dlg prompts 
back with the dlg again untill user clicks ok.
But checked this on linux using 2001-06-29-06 build and this did not work for 
linux. Reopening this bug for linux only.  

Comment 9

[Navin Gupta]

It works on linux as well using the latest debug build. marking fixed again.

Comment 10

[Sheela Ravindran]

used today's trunk build-2001070606 linux
Worked for me too:)