871871 - Submitting a review fails with a 409 Conflict

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Navigate to the details page for Twitter
2. Navigate to the review details page
3. Click on "Write a review"
4. Select a rating and then add a comment
5. Click Submit

observed behavior:
Review submission fails with a 409 Conflict

http request [
POST /api/v1/apps/rating/?_user={blah blah}&dev=firefoxos&format=json&lang=pl&pro=fbff7fdc.32.1&region=us HTTP/1.1
Host: marketplace-dev.allizom.org
User-Agent: Mozilla/5.0 (Mobile; rv:18.0) Gecko/18.0 Firefox/18.0
Accept: */*
active [1] { handler=48766cf0 condition=0 pollflags=5 }
active [0] { handler=46fa7f20 condition=0 pollflags=5 }
idle [0] { handler=47ab78e0 condition=0 pollflags=6 }
active=3 idle=1
active=3 idle=0
calling PR_Poll [active=3 idle=0]
timeout = 65535000 milliseconds
Accept-Language: pl,en-us;q=0.7,en;q=0.3
Accept-Encoding: gzip, deflate
Referer: https://marketplace-dev.allizom.org/app/twitter/ratings/add
Content-Type: application/x-www-form-urlencoded; charset=UTF-8
X-Requested-With: XMLHttpRequest
Content-Length: 30
Cookie: __utma=117863061.1412236192.1368473654.1368483634.1368496327.3; __utmz=117863061.1368473654.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none); __utmb=117863061.18.10.1368496327; __utmc=117863061; lang="pl\054"; region=us; carrier=telefonica
Connection: keep-alive
Pragma: no-cache
Cache-Control: no-cache
]
nsHttpTransaction::HandleContentStart [this=440361d0]
Duration:        0.873 440361d0       (marketplace-dev.allizom.org -> POST /api/v1/apps/rating/?_user=krupa.mozbugs%2B57g%40gmail.com%2C84c291180794d452bab12a08067f31aa0c9c51f5093d04cfe659265f33b41bbf7862e03a12a12e4486da1bf7b7916717d50fff237edd083841d3476678fef53a%2Cc5e5f96262d34df5b582b334533f0eeb&dev=firefoxos&format=json&lang=pl&pro=fbff7fdc.32.1&region=us)
 http response [
HTTP/1.1 409 CONFLICT
Server: gunicorn/0.17.4
Vary: API-Filter, X-Requested-With, Accept-Language, Cookie, X-Mobile, User-Agent, Accept-Encoding
Content-Type: text/html; charset=utf-8
Content-Encoding: gzip
Access-Control-Expose-Headers: API-Filter, API-Status, API-Version
Strict-Transport-Security: max-age=2592000
Date: Tue, 14 May 2013 02:05:38 GMT
Transfer-Encoding: chunked
Access-Control-Allow-Origin: *
X-Content-Security-Policy-Report-Only: policy-uri /services/csp/policy?build=9e9e
Via: Moz-pp-zlb09
Connection: keep-alive
API-Filter: carrier=telefonica&device=gaia&lang=pl&region=us
Access-Control-Allow-Methods: GET, POST, OPTIONS
Access-Control-Allow-Headers: X-HTTP-Method-Override, Content-Type
API-Version: 1
]

Comment 1

[Wil Clouser [:clouserw]]

Andy: we're not sure if this is in the API or not.  Can you investigate and work with #amo for questions?

If it's blocking all reviews we can't push with it

Comment 2

[Christopher Van Wiemeersch [:cvan]]

http://firefox-marketplace-api.readthedocs.org/en/latest/topics/ratings.html
API docs say "409 – the user has previously rated the app, so Update should be used instead."

Comment 3

[Matt Basta [:basta]]

If we get a has_rated, we always show an Edit Review button. If we get a can_rate or the user isn't signed in, we show a Write a Review button.

Either way, there shouldn't be a case where we are hitting the wrong URL. We have pretty good tests that test that we're doing the right thing, so I'm pretty sure this is the API being out of sync.

Why doesn't posting a new review overwrite an existing review for that app? That seems like appropriate behavior in this case.

Comment 4

[Andy McKay]

I think its perfectly reasonable for the API to enforce correct HTTP headers being sent. I haven't been able to reproduce this yet, it works fine on stage and -dev for me.

Comment 5

[krupa raj[:krupa]]

STR:
1. Log in to marketplace-dev
2. Go to the details page for an app like Accuweather
3. Add a review
4. Log out
5. Reload the page (I used a different browser because of https://github.com/mozilla/browserid/issues/3386)
6. As an anonymous user, click on 'Write a review' button
7. Log in with the same credentials used in #1
8. Add a review.

expected behavior:
Once the user logs in, we detect that they have added a review already and load the Edit review screen.

observed behavior:
We load the Write review form and submission fails.

Comment 6

[Andy McKay]

In #remora both chuck and I think this is an issue in fireplace.

Comment 7

[Chuck Harmston [:chuck]]

Yeah, it appears that after step #7 in Krupa's STR, Fireplace doesn't check for `has_rated` on the newly-authenticated user and adjust the displayed form appropriately.

Comment 8

[Davor Spasovski [:spasovski]]

This should force a login to get to any add/edit review page.

https://github.com/mozilla/fireplace/commit/c9afb32

Comment 9

[Victor Carciu]

Verified as fixed using STRs from comment #5.
Please see screencast with "Edit review" button in Chrome : http://screencast.com/t/yU8xXXtgZU