871930 - [Dialer] Information is not represented when making a call using contacts list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Leo]

1. Title : Information is not represented when making a call using contacts list
2. Precondition : Saved contact // (ex) name : Test / number : 21113754
3. Tester's Action : Making a call 
4. Detailed Symptom : Contact information is not represented
5. Expected : Contact information is represented normally
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train : Reproduced
8. Gaia Revision : d5f7b2d3f7acc04c35abda8b001262d8912f9dfe
9. Gecko Revision : 0ab3418551bfcefe1e14633f8f2b0422707a4c2f
10 Personal email id : [e-mail]

Comment 1

[Leo]

Attachment: Not represent information

This bug relates Bug 859185

Comment 2

[Etienne Segonzac (:etienne)]

Unable to reproduce this bug (with the exact same phone number).
Used the exact same steps as in the video.

Can you test again and close WORKSFORME if it works?

Comment 3

[promise09th]

Leo device is already repreduced this issue.
So, we check that this is real issue.

Comment 4

[promise09th]

I check other device below version, this device also reproduce this issue.

Software : Boot2Gecko 1.1.0.0-prerelease
Gaia Commit: 0d5f55fef5b46b8a53b87daed9abe3b9a37ce3221369088022
Gecko Commit: ada3b9647e60742aacee32918596c0ae022df1cb

Please check this version.

Comment 5

[Etienne Segonzac (:etienne)]

I tested with the gaia changeset 0d5f55fef5b46b8a53b87daed9abe3b9a37ce322 (the one given wasn't working) and still could not reproduce.

I wonder it this is mcc/sim related, I'll attach a patch adding some logging in order to figure this out.

Can you try again with this patch and attach the resulting logcat to this bug? Thanks!

Comment 6

[Etienne Segonzac (:etienne)]

Attachment: Patch adding debug logs

Comment 7

[Leo]

Attachment: Variants log

These numbers are saved in contacts.

But device shows only last number "01021113691".

Information of other numbers is not represented in call screen.

Comment 8

[Leo]

(In reply to Leo from comment #7)
> Created attachment 752484 [details]
Variants log

These numbers are saved in
> contacts.

But device shows only last number "01021113691".

Information of
> other numbers is not represented in call screen.

device only shows information of number "01021113691".

Comment 9

[Etienne Segonzac (:etienne)]

Hey Reuben, do you know if it's by design that the 13754 isn't matching 21113754?

I thought the "match" keyword worked pretty much like an "endsWidth".

Comment 10

[Reuben Morais [:reuben]]

(In reply to Etienne Segonzac (:etienne) from comment #9)
> Hey Reuben, do you know if it's by design that the 13754 isn't matching
> 21113754?
> 
> I thought the "match" keyword worked pretty much like an "endsWidth".

Etienne, "match" only matches the full number, with the international and national formats. So "13754" will only match a contact if it has a telephone number of "13754" or say, "+5513754".

Comment 11

[Bruce Huang [:bhuang] (inactive)]

Does this only repro if you dial the entire number manually?  For example if you dial the first few numbers, then select the autocomplete suggestion will it show the contact name correctly?

Comment 12

[Leo]

Attachment: Using Suggestion bar and contacts

When making a call using autocomplete suggestion and contacts, same result occurs.

I attach video.

Comment 13

[Etienne Segonzac (:etienne)]

(In reply to Reuben Morais [:reuben] from comment #10)
> (In reply to Etienne Segonzac (:etienne) from comment #9)
> > Hey Reuben, do you know if it's by design that the 13754 isn't matching
> > 21113754?
> > 
> > I thought the "match" keyword worked pretty much like an "endsWidth".
> 
> Etienne, "match" only matches the full number, with the international and
> national formats. So "13754" will only match a contact if it has a telephone
> number of "13754" or say, "+5513754".

Good to know :)

So basically the SimplePhoneMatcher used in the Dialer app isn't compatible with the way the "match" requests work.
(The SimplePhoneMatcher sends a request for the shortest variant and then looks up the best match in the results.)

We probably want to remove the SimplePhoneMatcher anyway and trust the mozContacts API for the tricky matching (like the SMS app does).

But this won't be trivial, and might have severe implications for the Facebook contacts lookup.

Comment 15

[Etienne Segonzac (:etienne)]

A leo+ bug was marked as a duplicate of this one BTW.

Comment 16

[David Scravaglieri [:scravag]]

According to comment 13 and as it is also a duplicate of a blocker: Blocking.

Comment 17

[Andreas Gal :gal]

Etienne, are you working on this? This is part of the WW sprint.

Comment 18

[Etienne Segonzac (:etienne)]

Attachment: Proposed patch

We still need the SimplePhoneMatcher for the facebook lookup, but we're now sending the number directly to the mozContact API for match requests instead of one of the variants.

Good thing is, it makes the patch real simple.

Probably worth to QA properly though.

Comment 19

[Andreas Gal :gal]

leo QA team, we have a proposed patch. Can you apply the patch and test it?

Comment 20

[Leo]

I check the patch, it is working well. But, some cases should discuss. 

Save in contact : 01021113754 (name : test)
Call number : 1021113754

In this case, when making a call using number "1021113754", device find "test".
But, this relates phone matching algorithm. 

I already report Bug 871939. I think you watch this issue with Bug 871939.

Comment 21

[Leo]

In addtion, when making a cll using number "021113754", device can't find any contact.

Comment 22

[Etienne Segonzac (:etienne)]

So basically this patch delegates all the phone matching issues to gecko.

We should file platform bugs for the follow ups, but they will be fixed for the dialer and the sms app at the same time from now on.

Comment 23

[Andreas Gal :gal]

Ok, cool. Lets land this and track the remaining issues in bug 871939.

Comment 24

[Andreas Gal :gal]

I am adding more tests for this to bug 871939.

Comment 25

[Andreas Gal :gal]

etienne, can you please land this?

Comment 26

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/2ca71e378a9930e166690df3298df8478080a4b8

Comment 27

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 2ca71e378a9930e166690df3298df8478080a4b8 to:
v1-train: 56ebf9b4d6384b4ef39ac5ddcf1698162bd76936

Comment 28

[Parul Mathur]

Added test case in MozTrap: 
https://moztrap.mozilla.org/manage/case/8514/

Comment 29

[Parul Mathur]

Executed test case https://moztrap.mozilla.org/manage/case/8514/ and verified fixed on:
Device: Leo phone 
Build Identifier: 20130611074722
Update channel: leo/1.1.0/nightly
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8d0562d20324
Gaia: 8c64e19b82d4e0490a7780232d3d6bd07d0ba9ec1370937291
Git commit info: 2013-06-11 07:54:51 
OS version: 1.1.0.0-prerelease

and

Device: Unagi phone 
Build Identifier: 20130611074722
Update channel: unagi/1.1.0/beta
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8d0562d20324
Gaia: 8c64e19b82d4e0490a7780232d3d6bd07d0ba9ec1370937291
Git commit info: 2013-06-11 07:54:51 
OS version: 1.1.0.0-prerelease