Closed Bug 872159 Opened 11 years ago Closed 11 years ago

Defect - Flyout panels have a different border than permissions flyout

Categories

(Firefox for Metro Graveyard :: Theme, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
Theme
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 24

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

(Whiteboard: feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=1)

Attachments

(2 files)

Patch v1.
1.79 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review
permissions flyout
232.84 KB, image/png
Details 
The permissions flyout border is different from the other flyouts. It seems to be 2 pixel gray; whereas the permissions one is only 1 pixel and doesn't go into the header.

p=1
Priority: -- → P2
Summary: Flyout panels have a different border than permissions flyout → Defect - Flyout panels have a different border than permissions flyout
Whiteboard: feature=defect c=tbd u=tbd p=0
This is one of Asa's annoyances from the meeting today.
Asa please post followup for similar issues if you see them, they only take like t or 10 minutes to fix.
Assignee: nobody → netzen
Blocks: metrov1it7
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=1
Attached patch Patch v1. — — Splinter Review 
This emulates the border colors of the permissions flyout
Attachment #749421 - Flags: review?(mbrubeck)
Anyone suggest a story this Defect could be related to?
Blocks: 831958
QA Contact: jbecerra
Whiteboard: feature=defect c=tbd u=tbd p=1 → feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=1
Attachment #749421 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/0b319e0d6238
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
For testing and verification.
Flags: needinfo?(jbecerra)
Attached image permissions flyout — 
Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20130516 Firefox/24.0
This looks fine to me - consistent with other flyouts. Setting to verified.
Flags: needinfo?(jbecerra)
Status: RESOLVED → VERIFIED
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130819030205
Built from http://hg.mozilla.org/mozilla-central/rev/c8c9bd74cc40

WFM
Tested on windows 8 using latest nightly for iteration-12. Permission flyout is consistent with other flyouts.
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: