872173 - Timezone information lost when reading ics file, all times converted to floating

Status: RESOLVED FIXED

(Calendar :: ICAL.js Integration, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: testcase

When opening a calendar all timezone information is lost. Times are converted to floating.

STR:
1. Set calendar.icaljs to true, restart Thunderbird
2. Use menu File > Open > Calendar File to subscribe to a local ics calendar file
3. Select an event an inspect its timezone, e.g. in the Event Dialog

Error:
Event times are shown as floating instead of the original timezone.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This takes care. One issue was that the ical.js timezone service didn't have any timezones, the other was the referenced timezone methods I didn't implement.

I'm not quite happy with the referenced timezones implementation, but its almost like the libical version and James has plans to rewrite some of the timezone bits of ical.js. Therefore it doesn't make sense to integrate timezone refcounting into ical.js right now.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Fixes an error with recurring events

Comment 4

[Matthew Mecca [:mmecca]]

Comment on attachment 751476 [details] [diff] [review]
Fix - v2

r=mmecca

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 1f614bd1e4b3