87290 - Plugin MIME-type attribute should not be case sensitive

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Henrik Gemal]

If I go to:
http://www.bmwfilms.com/site_layout/filmstream.asp?FilmID=1&Type=QT&size=large&d
ir=off

I'm unable to see the quicktime movie even though I can see other quicktime 
movies other places like http://www.apple.com/trailers/wb/ai_trailer.html

build 20010621 on win2k
quicktime 5.0.1

Comment 1

[Henrik Gemal]

On there embed tag they use
type="video/QuickTime"

I can see the movie with Netscape 4.x

on apple.com/trailers they dont use type="video/QuickTime"

Comment 2

[shrirang khanzode]

i confirm the bug...works fine on 4.x 

Comment 3

[Peter Lubczynski]

The default plugin shows up instead.

I wonder if this is string case comparison problem as it's listed as
video/quicktime in about:plugins. Does case matter on the content-type in the
embed tag? Need a simplified test.

Comment 4

[Henrik Gemal]

test case is now available at:
http://gemal.dk/test/qt.html

Very simple test case:
<embed src="qt.mov" type="video/QuickTime">
<embed src="qt.mov" type="video/quickTime">
<embed src="qt.mov" type="video/quicktime">
<embed src="qt.mov">

Mozilla will only play the last two! So it is indeed a case comparison problem. 
Should be fixed asap....

Comment 5

[shrirang khanzode]

Thnx, henrik!!

Comment 6

[Peter Lubczynski]

Attachment: patch to ignoring case for MIME type and file extension comparisons

Comment 7

[Peter Lubczynski]

Attachment: better (compiling) patch that uses PL_str functions

Comment 8

[av (gone)]

r=av

Comment 9

[Marc Attinasi]

sr=attinasi

Comment 10

[Peter Lubczynski]

Arun,

Can you see if PDT will accept this bug? It appears that without out, specifying
the mime-type or extension in html must match that case of what the plugin
vendor hard coded in the plugin.

Comment 11

[Peter Lubczynski]

Patch checked into the TRUNK.

Comment 12

[Peter Lubczynski]

Nominating nsbranch. This seems like a low-risk fix to me.

Comment 13

[Peter Lubczynski]

Adding vtrunk because fix is in the trunk and needs to be verified.

Comment 14

[Peter Lubczynski]

Changing summary from:
Unable to see quicktime movie at bmwfilms

Comment 15

[Henrik Gemal]

I can now see the movie and bmwfilms.com

using 20010705 trunk

Comment 16

[shrirang khanzode]

removing 'trunk' per henrik's comment.

Comment 17

[Peter Lubczynski]

PDT+ per plugin meeting

Comment 18

[Peter Lubczynski]

Patch is in now in both the branch and the trunk. Marking FIXED.

Comment 19

[shrirang khanzode]

verif on trunk and branch 070904 that the movie now appears to load. On 4.x 
also, it does not play ...but at least  Isee same behaviour on 4.x and 6.x now. 
VERIFIED