873201 - Switch desktop Marketplace Persona URLs to firefoxos.persona.org

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Kumar McMillan [:kumar]]

Update both the desktop Marketplace include.js and verifier to firefoxos.persona.org

jedp: clouserw, kumar: you tell marketplace to use the same server we're using for mobile until all the persona changes make it into the production train
jedp: clouserw, kumar: this would fix three big things
jedp: clouserw, kumar: 1. it would get everyone on the same database, and there would be no weird "why do i have to re-create my account?" qhestions
jedp: clouserw, kumar: 2. it would get you all the fixes we're putting in right away
jedp: clouserw, kumar: 3. we would be able to t=respond much faster to your needs, with 24-hour turnaround for bugs, which we can't always do with production and stage

A specific issue we're trying to fix: https://github.com/mozilla/browserid/issues/3386

Comment 1

[Kumar McMillan [:kumar]]

This change is only temporary.

jedp: kumar so the only other change in the future would be to point marketplace back to login.persona.org the day that code hits production later this month

Comment 2

[Kumar McMillan [:kumar]]

Fixes for this:

https://github.com/mozilla/fireplace/pull/123
https://github.com/mozilla/zamboni/pull/766

We decided not to put this into prod with the fireplace launch because it would cause all existing users to re-create their accounts. This is because the login.persona.org DB has not merged -- the merge happens 6/4

Comment 3

[Kumar McMillan [:kumar]]

I don't know if we made a decision on when to flip this yet -- maybe early next week?

Comment 4

[Wil Clouser [:clouserw]]

Last I heard it would require people to re-register their accounts which is a no-go.  What's the latest plan?

Comment 5

[Kumar McMillan [:kumar]]

I'm not clear on the plan. I'm cc'ing Jed for when he's back to help answer.

Comment 6

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Kumar McMillan [:kumar] (on PTO 5/20-5/24) from comment #5)
> I'm not clear on the plan. I'm cc'ing Jed for when he's back to help answer.

Hi, all.  When we spoke last Thursday, you expressed your opposition to having all marketplace users directed at firefoxos.persona.org, because you did not want desktop users to have to re-create their accounts.  This is completely understandable.  So desktop and mobile marketplace are currently pointing at different persona systems.  desktop is pointing to our production login.persona.org service, and mobile is pointing at a separate firefoxos.persona.org system.

We've currently set up firefoxos.persona.org as a stand-alone ephemeral instance in order to be able to respond in under 24 hours to any bugs you might uncover.  At the end of this week, that codebase will be on the train to arrive in production on 6/5.  After 6/5, we will turn firefoxos.persona.org into a CNAME for login.persona.org, the production persona system.  This means that mobile testers/users will have to create accounts on login.persona.org if they don't already have them.  But after that DNS switch, mobile and desktop will share the same accounts database.

Comment 7

[Matt Basta [:basta]]

Fireplace currently points at login.persona.org for desktop and firefoxos.persona.org when native persona is available. I guess we should just keep this bug open until the week of 6/5, at which point we'll get rid of the logic that switches between login/firefoxos and just make it all point to login?

Comment 8

[Andrew Williamson [:eviljeff]]

So... 6/5 has passed - does something need to happen now?

Comment 9

[Matt Basta [:basta]]

This is on my list of things to do today.

Comment 10

[Kumar McMillan [:kumar]]

Hold up on making the change. lloyd says the 6/5 release - http://personatra.in/#2013.05.22 - was delayed due to bug 871799. Says it will go out Monday maybe.

Comment 11

[Matt Basta [:basta]]

Ok. I'll make a pull request with the changes. One of the nice things we can do (if I understand correctly) is actually put the include.js script tag directly in the HTML:

    <script src="https://login.persona.org/include.js" defer></script>
    <script src="/media/js/l10n.js"></script>
    <script src="/media/js/include.js" defer></script>

Once that happens, login.js won't have to inject the script tag and Persona init can happen during AMD initialization, fixing bug 873132.

We should also get a nice perf win for allowing Persona to load asynchronously from our own JS bundle (and the slight drop in size for login.js when we remove the logic and settings for Persona's include.js).

Comment 12

[Matt Basta [:basta]]

To confirm with someone, after the release happens the unverified issuer (experimental_forceIssuer) should be "login.persona.org". Heyna or no?

Comment 13

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

:basta yes, you should be able to force login.persona.org at that point

Comment 14

[Matt Basta [:basta]]

Any update on whether we can land this?

Comment 15

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Matt Basta [:basta] from comment #14)
> Any update on whether we can land this?

The 05.22 train was just deployed about 20 minutes ago.  We're testing right now to make sure everything's good.

Comment 16

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

We've just cut firefoxos.persona.org over to be a cname for login.persona.org

When QA approves of the change, we can close Bug 884857 and you can update your config at your leisure.

Comment 17

[Matt Basta [:basta]]

My pull landed, so whenever we push it'll be in production.

Comment 18

[Andrew Williamson [:eviljeff]]

What's the status of this?  Is it fixed?

Comment 19

[Matt Basta [:basta]]

Yeah, this was fixed in lots of little pieces.