873418 - contentEditable elements are not considered clickable by the event fluffing code

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Sounds like a contentEditable item should be considered like an input element.

(Gaia use a contentEditable area for writing sms/mms).

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 750971 [details] [diff] [review]
Patch

Review of attachment 750971 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/PositionedEventTargeting.cpp
@@ +155,5 @@
>      if (content->AttrValueIs(kNameSpaceID_None, nsGkAtoms::role,
>                               nsGkAtoms::button, eIgnoreCase)) {
>        return true;
>      }
> +    if (content->HasAttr(kNameSpaceID_None, nsGkAtoms::contenteditable)) {

I think you should call IsEditable. We want to the descendants of a contenteditable element return true here too.

And please add a test.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v2 + tests

Comment 3

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/eeb4c68989f3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eeb4c68989f3