873429 - Form assistant suggestions is not dismissed while entering different letters

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Build: Aurora 23.0a2 05/16
Device: Asus Eee Transformers 
OS: Android 4.0.3

Steps to Reproduce:
1. Go to gmail.com
2. Enter a user name - tap enter - repeat with a different user name
3. Enter a 3rd user name - starting with different letter from the above 2

Expected Results:
- no suggestion present 

Actual Results:
- the first 2 names as present as suggestions 

Please see video - http://www.youtube.com/watch?v=pq2Wnc4mXVM . Suggestions can be dismissed if you will tap outside the form.

Comment 1

[Teodora Vermesan (:TeoVermesan)]

The regression window for this issue is:
1. mozilla central
good build: 11.05.2013 
bad build:  12.05.2013 

pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=179e29a23c56&tochange=d68224f5325b

2. inbound
good build: 1368163665
bad build:  1368166544

pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6035591d40f8&tochange=96fe69d53f35

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Looks like async form history broke this.

Comment 3

[:Margaret Leibovic]

I'll investigate.

Comment 4

[:Margaret Leibovic]

Attachment: patch

Yo dawg, there are a lot of callbacks in this code. Turns out there were two slight logic errors that caused us to never call _hideFormAssistPopup when we should.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 751868 [details] [diff] [review]
patch

Off topic: I just realized I have a strong dislike for "fat arrow" function syntax. It's the work of the devil.

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a239a5d19439

Comment 7

[:Margaret Leibovic]

Comment on attachment 751868 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 566746
User impact if declined: form autocomplete popup doesn't hide when it should
Testing completed (on m-c, etc.): tested locally (just landed on inbound)
Risk to taking this patch (and alternatives if risky): low-risk, isolated small logic fixes
String or IDL/UUID changes made by this patch: n/a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a239a5d19439

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a6ec7be9af2c