873466 - (Follow up) Remove single elements in the call log is not possible (delete all, works)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[alberto.pastor]

Follow up of Bug 847406

STR:

1.- Install gaia master
2.- Open the dialer
3.- Go to call log
4.- Enter edit mode and click one 1 call
5.- Delete
6.- Reopen the dialer

Expected

The call is not there anymore

Actual

After restarting, the call is still ther

Comment 1

[alberto.pastor]

Attachment: Pointer to PR 9848

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 751030 [details]
Pointer to PR 9848

Can't look in details why right now, but this patch wasn't working for me (commented on github with details).

Monday is a bank holiday in France, feel free to ask German for review to speed this up since I won't be able to look at it again before tuesday.

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 751030 [details]
Pointer to PR 9848

Hi guys! Looks good and working to me ;-) Thank you very much, Alberto! Once Travis is ready, I'd say we are good to go!

Comment 4

[alberto.pastor]

https://github.com/mozilla-b2g/gaia/commit/22bc959a5fda94aadfb11654ad5e8eaaaaa7db6b

Comment 5

[alberto.pastor]

Follow up of a leo+, so nominating

Comment 7

[Dylan Oliver [:doliver]]

leo+ -- blocking a blocker

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 22bc959a5fda94aadfb11654ad5e8eaaaaa7db6b
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 9

[Maria Angeles Oteo (:oteo)]

Alberto, can you help with the uplift??

Comment 10

[alberto.pastor]

It depends on the call log refactor, which uplift has been stop until a round of QA is executed on master. I'll uplift both together if we don't see any (important) regressions tomorrow.

Comment 11

[alberto.pastor]

v1-train: 4d10e1297b859cacc174c0a54af61a7678d7c32d

Comment 12

[zhangwei]

this bug appears on the firefox os 1.1.