873844 - [Buri][Notification]No missing call notification for the call from known number

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.107
 Firefox os  v1.0.1
 Mozilla build ID:20130514070202
 
 +++ This bug was initially created as a clone of Bug #455707 +++
 
 DEFECT DESCRIPTION:
 (1)Make an incoming call from a known number, don't answer it.
 (2)Then end the call from the other side. 
 (3)There is no missing call notification in lock screen also not in header bar.No matter the screen is locked or not locked. --- NOK.
 (4)Go to call history, you can find the missing call item in it.
 
 Note:
 If the missing call is coming from an unknown number, it is OK. There will be notification
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 There should be always missing call notifications
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 serious
 
  REPRODUCING RATE:
 100%
  For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #455707 description ++++++++++

Comment 1

[Amelie Kong]

Here , known number means the number is saved in contacts.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Investigating.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

There's a problem in dialer's lazy load mechanism.
It require Utils but doesn't load it before notification handling.


Patch coming.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/9871 patch for v1.0.1

This bug occurs in all branches but this patch is for 1.0.1 now.
Load Utils before notification message handler.

There may have alternative to laod Utils so if etienne has different opinions please point out.

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 751589 [details]
https://github.com/mozilla-b2g/gaia/pull/9871 patch for v1.0.1

I'm stealing the review here because of deadlines. Code looks good, and it even worked in my tests!

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

v1.0.1: 3525cba

It doesn't look like this is applicable to v1-train or master, but please let me know if this is not correct.

Alive, do you know if this fix is applicable to v1-train or master?

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to John Ford [:jhford] -- If you expect a reply from me, use needsinfo? instead of CC from comment #6)
> v1.0.1: 3525cba
> 
> It doesn't look like this is applicable to v1-train or master, but please
> let me know if this is not correct.
> 
> Alive, do you know if this fix is applicable to v1-train or master?

John, I will do the uplift because there're some conflict in this code section.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

master
https://github.com/mozilla-b2g/gaia/commit/1092531a41213ca82d2058e8541557397af1bcbc

v1-train
https://github.com/mozilla-b2g/gaia/commit/c51082d92f18c4c7cdbc4f96c977be735500562a

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Change component to dialer since this exactly is a dialer bug ;)

Comment 10

[mdaniloff]

This issue no longer reproduces on both V1.1 and V1.0.1 User is able to see missed call notification from both a known number and unknown number. 


Leo Mozz build V1.1: 20130530070208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09ac1fd2959c
Gaia: 1cca9324d4444ad28c6fa99875e17abf7e8230be
Version 18.0

Buri Mozz V1.0.1 build: 20130530070213
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/11b55d3ada71
Gaia: ac293ce59acc3bede083fad1b973794fa8bf0253
Version 18.0

Comment 11

[sync-1]

Comment from Mozilla:This issue no longer reproduces on both V1.1 and V1.0.1 User is able to see missed call notification from both a known number and unknown number. 
 
 
 Leo Mozz build V1.1: 20130530070208
 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09ac1fd2959c
 Gaia: 1cca9324d4444ad28c6fa99875e17abf7e8230be
 Version 18.0
 
 Buri Mozz V1.0.1 build: 20130530070213
 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/11b55d3ada71
 Gaia: ac293ce59acc3bede083fad1b973794fa8bf0253
 Version 18.0