Closed Bug 873913 Opened 11 years ago Closed 11 years ago

undefined reference to 'vtable for mozilla::CameraPreviewFrameCallback'

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: slee, Assigned: slee)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][b2g-webrtc+][qa-])

Attachments

(1 file, 1 obsolete file)

patch - v2
864 bytes, patch
slee
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
On B2G, it has linking error as the following

../../../../unagi/prebuilt/linux-x86/toolchain/arm-linux-androideabi-4.4.x/bin/../lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin/ld: /home/mozalfredo/mozwork/mozilla-central-unagi/objdir-unagi/toolkit/library/../../content/media/webrtc/MediaEngineWebRTC.o: in function mozilla::CameraPreviewFrameCallback::CameraPreviewFrameCallback():/home/mozalfredo/mozwork/mozilla-centr
[11:18]  <alfredo> al-unagi/dom/camera/CameraPreviewMediaStream.h:14: error: undefined reference to 'vtable for mozilla::CameraPreviewFrameCallback'
Attachment #751545 - Flags: review?(kchen)
Whiteboard: [WebRTC][blocking-webrtc-][b2g-webrtc+]
Attachment #751545 - Attachment is patch: true
Comment on attachment 751545 [details] [diff] [review]
patch

Review of attachment 751545 [details] [diff] [review]:
-----------------------------------------------------------------

r+, make it a pure virtual function.
Attachment #751545 - Flags: review?(kchen) → review+
Attached patch patch - v2 — — Splinter Review 

        Attachment #751545 -
        Attachment is obsolete: true

        Attachment #753655 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/89eda39678bb
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Whiteboard: [WebRTC][blocking-webrtc-][b2g-webrtc+] → [WebRTC][blocking-webrtc-][b2g-webrtc+][qa-]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: