874003 - Remove preventBubble and preventCapture

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[David Bruant]

There is no plan in make a standard out of these Mozilla-specific methods. stopPropagation is what is used by developers (standard and better cross-browser compat)
They have no reason to exist as properties on Event.prototype anymore.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Need to be careful especially with preventBubble. Traditionally it has been used oddly often.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: patch

Let's try and see what's going on early in the cycle.
Currently preventBubble is no-op, so any code depending on preventBubble is broken anyway.
Try result: https://tbpl.mozilla.org/?tree=Try&rev=0fe79854849d

Comment 3

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/343242181775

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/343242181775

Comment 5

[Kohei Yoshino [:kohei]]

Updated:
https://developer.mozilla.org/en-US/docs/Web/API/Event
https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIDOMEvent
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_24

We should also consider removing (Bug 691151) or deprecating (Bug 726933) getPreventDefault. The nsIDOMEvent document says it has been deprecated since Gecko 16.0 but the bugs are still open.

Comment 6

[Masatoshi Kimura [:emk]]

(In reply to Kohei Yoshino from comment #5)
> https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_24

I think preventBubble and preventCapture should be explained in a separate clause.
These methods are not derived from Netscape but from the earlier W3C draft.
Chromium have never supported these methods from the start. And the replacement method is stopPropagation.

Comment 7

[Kohei Yoshino [:kohei]]

(In reply to Masatoshi Kimura [:emk] from comment #6)
> I think preventBubble and preventCapture should be explained in a separate
> clause.
> These methods are not derived from Netscape but from the earlier W3C draft.
> Chromium have never supported these methods from the start. And the
> replacement method is stopPropagation.

Thank you for the feedback. I just corrected the document.