Closed Bug 874258 Opened 11 years ago Closed 11 years ago

Warn if we run shutdown CC more than twice

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file, 1 obsolete file)

warn
1.68 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
What should happen, even with leaks, is that we run the CC twice at shutdown: once to free everything, then another time to confirm that there's nothing to free.

This wasn't actually always true, due to some weirdness that I fixed.

Anyways, warning for this will help figure out which shutdown CC we should log, in leaks like bug 858948.

If I'm feeling a little more brave, I'll make this an assertion.
Attached patch assert it (obsolete) — — Splinter Review 
Let's see if it fails as an assertion.
https://tbpl.mozilla.org/?tree=Try&rev=847064a62b8f
Attached patch warn — — Splinter Review 

        Attachment #751891 -
        Attachment is obsolete: true

        Attachment #753896 -
        Flags: review?(bugs)

        Attachment #753896 -
        Flags: review?(bugs) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/6d43a8c88ddc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: