875229 - DocumentLocalized not rising in Chrome

Status: RESOLVED WORKSFORME

(L20n :: HTML Bindings, defect)

Description

[Silent Imp]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.93 Safari/537.36

Steps to reproduce:

document.addEventListener('DocumentLocalized', function(){alert('l20n is ready');});



Actual results:

it work fine in FF, but don't work in Chrome


Expected results:

L20n must work in any browser

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

The only bug I found in Chrome is that we use "const" in strict mode. I switched it to var, since const is not part of ECMA.

With this change I get an alert window.

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 758734 [details] [diff] [review]
patch

Review of attachment 758734 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch. r=me.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

https://github.com/l20n/l20n.js/commit/b0cce61641a4d88ee94bb65c2221a4bbbb872ede

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Reporter, can you confirm that the code in question works in Chrome for you now?

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

closing for now. If the bug still exists, please, reopen.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

clearing NI