875545 - Make Telephony.h/cpp to use EventListenerAdded/Removed

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: wip

Totally untested patch since I haven't figured out how to compile
Telephony.h/cpp
https://tbpl.mozilla.org/?tree=Try&rev=56fd506a31c1

But I'll test the changes to EventListenerManager tomorrow.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

https://tbpl.mozilla.org/?tree=Try&rev=883f84a58c57

Maybe this compiles

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 753766 [details] [diff] [review]
v2

The ELM part is a bit ugly.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 753766 [details] [diff] [review]
v2

>+    bool same = scriptListener->GetHandler().Ptr() && aHandler.Ptr() &&
>+                scriptListener->GetHandler().Ptr()->CallbackPreserveColor() ==
>+                aHandler.Ptr()->CallbackPreserveColor();

Maybe put this in an operator== on nsEventHandler?

>+  void EventListenerAdded(nsIAtom* aType);

virtual, and MOZ_OVERRIDE.

r=me with that.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v3

https://hg.mozilla.org/integration/mozilla-inbound/rev/8cf923305a85

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8cf923305a85