875724 - No close button in the plugin doorhanger UI (UI consistency?)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Frank Wein [:mcsmurf]]

I've noticed that the plugin doorhanger UI in Firefox has no close button (an X usually :). Other doorhanger user interfaces like the "Remember Password" doorhanger or the HTML5 geolocation doorhanger have a close button. So I wonder if the plugin doorhanger UI should also get a close button?

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Comparison of different doorhanger UIs

Comment 2

[Frank Wein [:mcsmurf]]

Just for reference: Looks like in Bug 754472 Comment 5 and 6 there was some talk about removing the close button from PopupNotifications in general. So maybe this bug here is actually WONTFIX, it looks like there was no decision reached back then on what should happen.

Comment 3

[Georg Fritzsche [:gfritzsche]]

This inconsistency will be fixed by the new click-to-play UI, which is specced here:
http://people.mozilla.com/~lco/CtP/current/

The new UI should land in Fx 24.

Comment 4

[[:Aleksej]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #3)
> This inconsistency will be fixed by the new click-to-play UI, which is
> specced here:
> http://people.mozilla.com/~lco/CtP/current/

Will that also apply to the plug-in installation suggestion?  Because currently it looks too pressing to install a plug-in I don't want: although I can refuse to install Flash by clicking elsewhere or pressing Esc,
* consent appears to be the default,
* there is a "Not now" menu item, which is not that easy to choose, but it is still there, suggesting that it is the only or best way to opt-out (because who needs it when Esc or clicking elsewhere are so much easier and faster?).

Comment 5

[[:Aleksej]]

*clicking elsewhere or the close button

Comment 6

[Benjamin Smedberg]

No, the install suggestions are a different doorhanger. Although I hope to roll them up in the single doorhanger in a followup. In any case this bug as filed is FIXED by bug 880735.