876055 - Add default settings for some new device storage settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Dave Hylands [:dhylands]]

As suggested in the review of bug 875637, this bug adds the default values for:

device.storage.writable.name to be 'sdcard'

and for ums.volume.sdcard.enabled to be true.

This should be leo+

Comment 1

[Dave Hylands [:dhylands]]

Attachment: Added defaults for the new settings in device storage and the automounter.

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 754061 [details] [diff] [review]
Added defaults for the new settings in device storage and the automounter.

These options were introduced in bug 856782 (settings app) and used by the patches in bug 858416 (device storage) and bug 852768 (automounter)

Comment 3

[Gregor Wagner [:gwagner]]

Comment on attachment 754061 [details] [diff] [review]
Added defaults for the new settings in device storage and the automounter.

Review of attachment 754061 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Dave Hylands [:dhylands]]

https://github.com/mozilla-b2g/gaia/commit/1dd7b39de59258cce237d5ae732ecac1c3868cc5

Comment 5

[Walter Chen[:ypwalter][:wachen]]

I think this is also needed for v1train

Comment 6

[Ryan VanderMeulen [:RyanVM]]

(In reply to Dave Hylands [:dhylands] from comment #4)
> https://github.com/mozilla-b2g/gaia/commit/
> 1dd7b39de59258cce237d5ae732ecac1c3868cc5

John, can you assist with the uplift please?

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 5d79485

Comment 8

[Tony Chung [:tchung]]

in-moztrap-, as i dont think there is UI for this to test against.

Comment 9

[Dave Hylands [:dhylands]]

There is currently no UI for this feature. It was added for the new apps which want to present places to save data to the user.

The ds-test app can expose this (I've made some changes to ds-test, but haven't checked it in yet).