876222 - Remove the separator indentation in viewPickerPopup

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

+++ This bug was initially created as a clone of Bug #861933 +++

I'd say the indented menuitems are less desirable than the partially completed separators, so let's go with this patch for now.

But please file a follow-up bug to do something about those separators, if you haven't already.

Comment 1

[Richard Marti (:Paenglab)]

The indentation happens only on default theme, so put the rule in @media (-moz-windows-default-theme).

The original separator color is #E0E0E0. With ThreeDLightShadow we are using #E3E3E3. This should be close enough and not visible as they aren't mixed in this popup.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: patch

Oops, somehow the patch wasn't attached.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: screenshot for easier ui-r

Comment 4

[:aceman]

On Windows XP (without the patch) the separators are full width but the "Tags" and "Custom views" items are indented. Is that how it should be?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 754209 [details] [diff] [review]
patch

Looks good! Thanks!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/32140632beac