876615 - Remove Vivo bookmarks in the browser

Status: RESOLVED DUPLICATE of bug 840011

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Beatriz Rodríguez [:brg]]

Remove Vivo bookmarks info from the bookmarks in the browser.
you can reproduce this issue with unagi device in v1.0.1 and v1-train.

Steps to reproduce:
open browser
Create new tab
Go to bookmarks option and there will be 3 vivo bookmarks.

Please remove this 3 bookmarks.

Comment 1

[Jason Smith [:jsmith]]

I thought there was a reason why we had these Vivo bookmarks. Can't remember why, but there was a reason for having them.

Comment 2

[Daniel Coloma:dcoloma]

(In reply to Jason Smith [:jsmith] from comment #1)
> I thought there was a reason why we had these Vivo bookmarks. Can't remember
> why, but there was a reason for having them.

Adding ni on Ben to check if he remembers. Wouldn't it be better replacing it with some Mozilla Bookmarks?

Comment 3

[[e-mail]]

Why tef+ ?

Currently Bookmarks are already customized to spain and latam bookmarks via our customization distribution, it means tef rom wont be shipped with these 3 bookmarks.
So it's not matter to current ROM Certify process.


But I thinks its a good thing to provide some sensible default bookmarks for gaia repo.

Comment 4

[Daniel Coloma:dcoloma]

Can we check if all the partners are already replacing the default bookmarks for the target markets? If that is the case, I agree we should not block on this one. Who can check this?

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

Amelie should confirm on her end

Comment 6

[[e-mail]]

I think it's good to remove from default, but may not block as tef+

I'll send PR first due to the urgency of tef+.
r? to Ben and let him decide.

Comment 7

[[e-mail]]

Attachment: pull request redirect to github

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Can partner customization include overriding, or removing these defaults?  If yes, this is not a blocker.

Comment 9

[Ben Francis [:benfrancis]]

(In reply to [e-mail] [:lsblakk] from comment #8)
> Can partner customization include overriding, or removing these defaults? 
> If yes, this is not a blocker.

Yes. The bookmarks are set at build time as part of customisation, these are just the defaults in the applications-data.js file. We could pick different defaults but this shouldn't be tef+

Comment 11

[Daniel Coloma:dcoloma]

Partners have confirmed they are modifying them. 

I do not have any issue with keeping them, at the end of the day, they are TEF Bookmarks, but I think it would be good for the project to have generic bookmarks. Up to you if you want to nominate for leo or request approval.

Comment 12

[Ben Francis [:benfrancis]]

Comment on attachment 755225 [details]
pull request redirect to github

Thanks for the patch Fred, we're waiting on product input on what the defaults should be in bug 840011 but you could move this patch to that bug in case we decide to just clear them.