877144 - [Email] Long email id bubble in read mail page is out of the screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Screenshot highlighting issue

+++ This bug was initially created as a clone of Bug #871449 +++

STR: Open Email App > Select an email whose address is long from Inbox/Sent/...

Expected Result: the long email address should be shown with ellipsis in peep bubble (same as for bug 871449)

Actual Result: the long email address overflows the width of the screen (see attached screenshot)

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #10075 - Truncate long email addresses

Quick CSS solution to truncate long email addresses with ellipsis.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 755346 [details]
Pull Request #10075 - Truncate long email addresses

So, right now we have a weird situation with the bubbles.  The composer bubbles end up with both msg-peep-bubble and cmp-peep-bubble on them.  I had requested psingapati try and refactor the style just into a general "peep-bubble" class in mail.css, but he ran into trouble.

Rather than duplicate the style, since both bubble types use "msg-peep-bubble", let's either just move the style directives in question into there or undertake the creation of the more generic class so we can avoid the duplication.  (msg-peep-bubble and cmp-peep-bubble should still exist for identification purposes, however)

Thanks!

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 755346 [details]
Pull Request #10075 - Truncate long email addresses

Thanks for the suggestions, Andrew!

I updated the patch creating a more generic "peep-bubble" class that takes care of text overflow and made the necessary changes to the styles -- this also fixes bug 871449 (overwrites the changes done there).

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 755346 [details]
Pull Request #10075 - Truncate long email addresses

Looks good!  Feel free to land.

Comment 5

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/967459442a5d1630fe9049743bc495bf0540cb7f

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 755346 [details]
Pull Request #10075 - Truncate long email addresses

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Email peep bubbles overflowing screen width
User impact if declined: Medium (visible for emails received from long addresses like '[e-mail]')
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Low (mainly CSS changes)
String or UUID changes made by this patch: No

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 755346 [details]
Pull Request #10075 - Truncate long email addresses

We're past the point of approval-gaia-v1 noms in 1.1's schedule. If you feel this is a critical blocker, please set blocking-b2g:leo+

Comment 8

[Alex Keybl [:akeybl]]

blocking-b2g:leo?*

Comment 9

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Taking into account the details of comment 6, requesting blocking-b2g:leo

Comment 10

[Wayne Chang [:wchang]]

Leo is not in today's triage, this bug is not critical for the partners who attended. Leaving decision to leo.

Comment 11

[Leo]

Please uplift the patch to v1-train.

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 967459442a5d1630fe9049743bc495bf0540cb7f to:
v1-train: 64d75a37bb1d79e2a4d728fb81d1ced145844e3f

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 64d75a37bb1d79e2a4d728fb81d1ced145844e3f