877476 - simple-storage should have 'clear' method

Status: RESOLVED WORKSFORME

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

It's hard to clean out require('simple-storage').storage , which fronts `manager.root`.  

While we're at it, it would be nice to expose the 'toJSON' aspect of it... already, simpleStore checks for type.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

P3, but patches welcome. :)

Comment 2

[Tomislav Jovanovic :zombie]

i started work on this, and realized the .storage property is totally accessible to addon code, can be enumerated, can be JSONified, and can even be set to anything. in short, this works:

> let ss = require('simple-storage');
> ss.storage.blah = 123;
> console.log(JSON.stringify(ss.storage));
> ss.storage = {};

that last line basically does what this bug is asking for, or am i misunderstanding something?

maybe by clear you mean to actually delete the stored json file?

Comment 3

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Tomislav, 

If that all works (and tests show it!) then I am completely satisfied.  Make sure to try it with more complex types than `int` though!  

I did not mean that it should have to delete the stored on-disk file.

Comment 4

[Tomislav Jovanovic :zombie]

hey Gregg,

i went through existing tests for simple-storage, and they do all sorts of things to `.storage`, including stuff like this.

ok, i'm gonna close the bug with "works for me", and if someone disagrees, they can reopen it..