877521 - [Contacts][UX] The warning message of add picture is wrong.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Askeing Yen[:askeing][:fyen]]

## STR:
0. Prepare some videos and no photo in Gallery app.
1. Open Contacts app.
2. Add contact.
3. Add Picture > Gallery.
4. Show warning message.

## Actual results:
The warning message title is "No photos or videos".

## Expected results:
The warning message title should be "No photos".

Comment 1

[Stephany Wilkes]

Non-blocking but assigning to Ayman to address in future.

Comment 2

[ayman maat :maat]

passing to Rob as the message is actually Gallery app side, not contacts app.

needInfo me Rob if you require anything

Comment 3

[Askeing Yen[:askeing][:fyen]]

Change the component

Comment 4

[Rob MacDonald [:robmac]]

Hi David...

Are we able to differentiate the empty state in the Gallery picker if we're filtering for photos only? Sorry for the delay on this one.

- Rob

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Hi Rob,

Yes, we are able to differentiate the empty state when we are in filtering mode. And gallery app only supports photo pick. So, we only need to load different empty message for pick activity.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: use different message title to show the warning message.

use different message title to show the warning message

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: different-warning-title.png

screenshot after this patch is applied.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: bug877521.zip

Rob, please help to do the ux review. I know this is a small patch. But according to our standard procedures, we need to put ux review when we change something in the UI.

Comment 9

[Rob MacDonald [:robmac]]

Comment on attachment 8340993 [details]
bug877521.zip

Hi John...

Although the screenshot that was attached to the bug appears to be correct, the zipped patch continued to state, "No photos or videos".

It could be a problem with the attachment but feel free to flag me to confirm.

Thanks!
Rob

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: bug877521.zip

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: correct version

Comment 12

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8342097 [details]
correct version

Rob,

Sorry for previous version. I compressed wrong folder. This one is correct. I had double checked. Please review it again.

Comment 13

[David Flanagan [:djf]]

Comment on attachment 8340990 [details] [review]
use different message title to show the warning message.

A trivially correct patch.  Simple enough to be completely safe for uplift to 1.3.  But maybe not important enough to bother uplifting.  I'll let UX decide whether to request uplift on this one.

Comment 14

[David Flanagan [:djf]]

Comment on attachment 8340990 [details] [review]
use different message title to show the warning message.

I did the review but forgot to set the flag.  r+ now.

Comment 15

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8342097 [details]
correct version

clear ui-review since this is a minor change.

Comment 16

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/a3913b3b4dc1075638181f898da3555b3108a58d