Closed
Bug 877714
Opened 11 years ago
Closed 10 years ago
Take a code walk along the API search/featured path
Categories
(Marketplace Graveyard :: Code Quality, defect, P2)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: robhudson, Unassigned)
References
Details
(Whiteboard: p=2)
Look for things we can optimize or cache.
Updated•11 years ago
|
Priority: -- → P2
Whiteboard: p=2
Updated•11 years ago
|
Assignee: nobody → amckay
Target Milestone: --- → 2013-06-27
Comment 1•11 years ago
|
||
I split out apps.search and apps.featured in graphite so we can see stats. apps.search has gotten faster, showing that apps.featured is the hog.
Comment 2•11 years ago
|
||
There are two main areas of interest: https://github.com/mozilla/zamboni/blob/master/mkt/search/api.py#L172 https://github.com/mozilla/zamboni/blob/master/mkt/search/api.py#L175 With 1 featured app we get: line 172: 86ms line 175: 35ms With 20 featured apps we get: line 172: 321ms line 175: 307ms
Comment 3•11 years ago
|
||
Cleaned up the first of those so its less O(n): https://github.com/mozilla/zamboni/commit/30b8ca Would like to take a look at the app dehydrate next.
Updated•11 years ago
|
Target Milestone: 2013-06-27 → 2013-07-04
Comment 4•11 years ago
|
||
It's still slow though: http://graphite1.dmz.phx1.mozilla.com/render/?width=586&height=308&_salt=1372463252.025&target=stats.timers.marketplace-dev.api.fireplace.featured.GET.upper_90&from=00%3A00_20130607&until=23%3A59_20130628
Updated•11 years ago
|
Assignee: amckay → nobody
Updated•11 years ago
|
Target Milestone: 2013-07-04 → 2013-07-11
Reporter | ||
Comment 5•11 years ago
|
||
https://github.com/mozilla/zamboni/commit/94b8704 added caching to one of the lower featured calls that is doing a complex SQL query.
Updated•10 years ago
|
Target Milestone: 2013-07-11 → ---
Comment 6•10 years ago
|
||
We did some of that a while ago in other bugs, but the API endpoint is going away anyway because of the feed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•