Closed
Bug 877798
Opened 11 years ago
Closed 11 years ago
Fix ssltap to print the correct label certificate_status (not request)
Categories
(NSS :: Tools, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.15.1
People
(Reporter: KaiE, Assigned: KaiE)
Details
Attachments
(1 file)
1.70 KB,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
ssltap labels the server's certificate status response as certificate_status_request, but it should say certificate_status.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #756124 -
Flags: review?(wtc)
Comment 2•11 years ago
|
||
Comment on attachment 756124 [details] [diff] [review] Patch v1 Review of attachment 756124 [details] [diff] [review]: ----------------------------------------------------------------- r=wtc. ::: cmd/ssltap/ssltap.c @@ +1317,5 @@ > sslh.length += s->hMACsize; /* skip over the MAC data */ > } > break; > > + case 22: /*certificate_status*/ Please add a space before and after certificate_status in the comment, like this: case 22: /* certificate_status */
Attachment #756124 -
Flags: review?(wtc) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/84dbcfce41d6 https://hg.mozilla.org/projects/nss/rev/23e6ea72c93f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Assignee: nobody → kaie
Priority: -- → P2
Comment 4•11 years ago
|
||
Kai: your checkin https://hg.mozilla.org/projects/nss/rev/84dbcfce41d6 included a change to secoid.c by mistake. Please revert that change.
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Wan-Teh Chang from comment #4) > Kai: your checkin https://hg.mozilla.org/projects/nss/rev/84dbcfce41d6 > included a change to secoid.c by mistake. Please revert that change. Sorry about that! It sneaked when I tried to reproduce an reported issue... Thanks for noticing the mistake. Reverted: https://hg.mozilla.org/projects/nss/rev/b1275e1acf8a
You need to log in
before you can comment on or make changes to this bug.
Description
•