Closed
Bug 877808
Opened 11 years ago
Closed 11 years ago
Plug remixed from into make details page
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thecount, Assigned: thecount)
References
Details
Attachments
(1 file)
bug 875580 is landing the makedetails page without a remixed from display. We're landing it in parts because it is blocked by bug 876441 The remixed from part has placeholder data at the moment.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #760173 -
Flags: review?(pomax)
Comment on attachment 760173 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/104 comments in pull request
Attachment #760173 -
Flags: review?(pomax) → review-
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 760173 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/104 Fixes.
Attachment #760173 -
Flags: review- → review?(pomax)
Comment on attachment 760173 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/104 few notes in the pull request - also, how can I test this with real data injected? I tried a publish, but its detail view seemed uninstantiated.
Attachment #760173 -
Flags: review?(pomax) → review-
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 760173 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/104 Updates.
Attachment #760173 -
Flags: review- → review?(pomax)
Comment on attachment 760173 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/104 I've got nothing left to complain about =)
Attachment #760173 -
Flags: review?(pomax) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Staged: https://github.com/mozilla/thimble.webmaker.org/commit/08c37dfbbddb53c48c9d15cc6cf1d06df1fd89b6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•