877960 - Update FTE to include geolocation notice

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Doug Turner (:dougt)]

FTE must include notice to user that Gelocation Location Services will send data to a 3rd party




"Use additional location services

Firefox OS uses data such as WiFi and mobile networks near you to help your device determine your approximate location more quickly and in places where GPS is not available. I recommend the box be checked.

[X] Enable additional location services.

Data is sent to Mozilla and other service providers and will be used in the aggregate to improve those location databases. Data may be stored on your device and data collection may occur even when no apps are running.

Comment 1

[Doug Turner (:dougt)]

required for enabling geolocation services on 1.1

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 3

[Doug Turner (:dougt)]

Attachment: default pref to checked

Comment 4

[Doug Turner (:dougt)]

sorry missed this second patch - we want to default it to checked like we had it before.

Comment 5

[[:fabrice] Fabrice Desré]

https://github.com/mozilla-b2g/gaia/commit/d29032e263c99842cd17dbd9a4d5be0117e770e4
https://github.com/mozilla-b2g/gaia/commit/640539e5a7918bff2034a6dc3ab4e2d43ff19b64

Comment 6

[Fernando Campo (:fcampo)]

This is causing a little regression on FTU UX, the last step marker is out of the screen. 
Sending a quick patch in couple of minutes, you can add it in here directly or open a followup

Comment 7

[Fernando Campo (:fcampo)]

Attachment: UX fix

Comment 8

[[:fabrice] Fabrice Desré]

Comment on attachment 756612 [details] [diff] [review]
UX fix

Review of attachment 756612 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Fernando. Feel free to push that to master.

Comment 9

[Fernando Campo (:fcampo)]

merged on master: https://github.com/mozilla-b2g/gaia/commit/d0e0de3a35fecffd1f0d1cbd01ebae2a1cfc373a

Should we close the bug or is there something still pending?

Comment 10

[[:fabrice] Fabrice Desré]

We can close it.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted d0e0de3a35fecffd1f0d1cbd01ebae2a1cfc373a to:
v1-train: c6bde0a88c6ff2a0bfe25db2d188abf9c1c89eb6

Comment 12

[Francesco Lodolo [:flod]]

Two questions/notes about the strings added in this bug.

geolocationInfo = Firefox OS uses data such as GPS, WiFi, and mobile networks near you to help determine your approximate location.

1) You should clearly use "Wi-Fi" instead of "WiFi", since that's the standard in all existing en-US strings.
2) Why hard-coding "Firefox OS" when all other strings in ftu.properties use "{{brandShortName}}"?

Let me know if you want me to open a new bug depending on this.

Comment 13

[Doug Turner (:dougt)]

Yes, this bug is fixed.  new bugs are cheap. please open new ones. :)