Closed
Bug 878079
Opened 11 years ago
Closed 11 years ago
Android |make install| message is misleading when no devices are connected
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: nalexander, Assigned: nalexander)
Details
Attachments
(1 file)
|
985 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This has pissed me off for the last time! Also, it confuses new contributors.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #756587 -
Flags: review?(ted)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 756587 [details] [diff] [review] Clarify |make install| message when no Android devices are connected. r=ted Review of attachment 756587 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/build.mk @@ +30,1 @@ > ifneq ($(android_devices),device) This is a little weird, because both of these conditionals will be true if there are no devices connected. I think wrapping this second conditional in an else/endif would be clearer.
Attachment #756587 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6d08264b017
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla24
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a6d08264b017
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•