878115 - DeviceStorage: sends too many volume events

Status: RESOLVED INCOMPLETE

(Core :: DOM: Device Interfaces, defect)

Description

[Dave Hylands [:dhylands]]

When using volume based storage areas on a leo phone, you wind up with a nsDOMDeviceStorage object for sdcard and extsdcard

Each of these register for NS_VOLUME_STATE_CHANGED events, and then convert these into change events with statuses of available, unavailable, or shared.

Two problems were discovered:

1 - when the sdcard nsDOMDeviceStorage object receives a volume state changed event for the extsdcard volume, it goes ahead and generates another change event

2 - since multiple volume states map onto the nsDOMDeviceStorage change events, it should remember the last change event it sent and only send out new ones.

Currently, mediadb is compensating for the multiple events, so this probably doesn't need to be leo+'d, but I'm going to go ahead and nom it anyways.

Comment 1

[Alex Keybl [:akeybl]]

(In reply to Dave Hylands [:dhylands] (Travellling until June 7) from comment #0)
> Currently, mediadb is compensating for the multiple events, so this probably
> doesn't need to be leo+'d, but I'm going to go ahead and nom it anyways.

Agreed, given no known user impact we won't block. But given theoretical impact we'd take a low risk fix.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

FxOS/Gonk has been removed from the codebase. Mass-invalidating FxOS related Device Interface bugs to clean up the component. 

If I incorrectly invalidated something, please let me know.

Comment 3

[Firefox Bug Husbandry Bot]

Bulk correction of resolution of B2G bugs to INCOMPLETE.