878292 - Profiler actor leaves the profiler running in some cases

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

... because it counts connections rather than active profilers, and doesn't stop if the last connection didn't start.

Comment 1

[Dave Camp (:dcamp)]

https://tbpl.mozilla.org/?tree=Try&rev=44f0f69b4217

Comment 2

[Anton Kovalyov (:anton)]

Comment on attachment 756777 [details] [diff] [review]
v1

Review of attachment 756777 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

I guess since it's not a regression fix we don't need a test case to cover your scenario (a starts profiler, disconnects, b doesn't start, disconnects)? Other than that, if try is clean: r+.

Comment 3

[Dave Camp (:dcamp)]

No, I should probably write a test...

Comment 4

[Anton Kovalyov (:anton)]

Ok. I'd write a test then—shouldn't be too time consuming.

Comment 5

[Dave Camp (:dcamp)]

Attachment: with tests

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 756862 [details] [diff] [review]
with tests

Review of attachment 756862 [details] [diff] [review]:
-----------------------------------------------------------------

what's up with all the Profiler.IsActive()s?

::: toolkit/devtools/server/tests/unit/test_profiler_activation.js
@@ +16,5 @@
> +
> +function run_test()
> +{
> +  // Ensure the profiler is not running when the test starts (it could
> +  // happen if the MOZ_PROFILER_STARTUP environment variable is set)

shouldn't ever happen in our generic mochitest environment should it?

Guess it's good to be safe.

@@ +18,5 @@
> +{
> +  // Ensure the profiler is not running when the test starts (it could
> +  // happen if the MOZ_PROFILER_STARTUP environment variable is set)
> +  Profiler.StopProfiler();
> +  Profiler.IsActive();

do you need IsActive() here? Should you do a do_check_false() on it or something?

@@ +34,5 @@
> +}
> +
> +function activate_first(client1, actor1, client2, actor2) {
> +  let Profiler = Cc["@mozilla.org/tools/profiler;1"].getService(Ci.nsIProfiler);
> +  Profiler.IsActive();

and here?

@@ +39,5 @@
> +
> +  // Start the profiler on the first connection....
> +  client1.request({ to: actor1, type: "startProfiler", features: ['js']}, startResponse => {
> +    dump("GOT RESPONSE HERE: " + Profiler + "\n");
> +    Profiler.IsActive();

what about this one?

Comment 7

[Dave Camp (:dcamp)]

Attachment: fixed tests

Comment 8

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/994dee02848d

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/994dee02848d