878493 - DeviceStorage: Invalidate used space cache if free space changes

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Dave Hylands [:dhylands]]

A used space cache was added to reduce the time it takes to calculate the amount of space used by the various file types.

However, if files are added/removed from the filesystem without going through device storage, then it won't know to invalidate the used space cache.

One fairly simple, and efficient way to cover this case is to invalidate the cache if the amount of free space changes (this implies that the used space also changed somehow).

Comment 1

[Dave Hylands [:dhylands]]

Attachment: invalidate used space cache if the free space changes.

This patch caused the used space cache retrieval to fail if the used space changes.
I also noticed that the GetUsedSizeForType function was no longer referenced anywhere, so I removed it.

Comment 2

[Dave Hylands [:dhylands]]

Attachment: invalidate used space cache if the free space changes. v2

Comment 3

[Dave Hylands [:dhylands]]

Comment on attachment 757366 [details] [diff] [review]
invalidate used space cache if the free space changes. v2

Review of attachment 757366 [details] [diff] [review]:
-----------------------------------------------------------------

I thought I'd send this your way. If you're too busy or don't feel comfortable reviewing, please let me know and I'll find somebody else.

Comment 4

[Jan Varga [:janv]]

Comment on attachment 757366 [details] [diff] [review]
invalidate used space cache if the free space changes. v2

Review of attachment 757366 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

Comment 5

[Dave Hylands [:dhylands]]

https://hg.mozilla.org/projects/birch/rev/b39f3b7995aa

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b39f3b7995aa

Comment 7

[Alex Keybl [:akeybl]]

https://bugzilla.mozilla.org/show_bug.cgi?id=876560#c7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/bc472d357309

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/bc472d357309