878502 - Aero tabbar shadow purple instead of gray/white

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[M4he]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.94 Safari/537.36

Steps to reproduce:

I'm running Thunderbird 17 on Windows 7 Professional x64 using Thunderbird's default theme.


Actual results:

There's a purple glow/shadow in the background of the tabbar region when Aero is enabled. Screenshot: http://i.imgur.com/3lTli4t.jpg

This texture was introduced with: https://bugzilla.mozilla.org/show_bug.cgi?id=793265 and is located at "mail/themes/qute/mail/icons/tabbar-background.png" within the source files. The color used at the center bottom pixel of this PNG is #9191BC which has a noticeable purple tint.
The purple color is kinda irritating and looks totally out of place.


Expected results:

The glow/shadow texture should have a neutral color, preferably gray or white instead of purple.

Comment 1

[rsx11m]

Confirmed, the semi-transparent tabbar-background.png makes an assumption on the color scheme of the underlying desktop theme which may result in irritating color combinations. It should be neutral (i.e., color saturation should be zero).

Comment 2

[Richard Marti (:Paenglab)]

Attachment: patch

This patch uses the approach from Firefox UX-builds (Australis).

Mike, sorry to fill your reviewer-queue but you are the specialist for this with your experience on FX-Australis.

Comment 3

[rsx11m]

Comment on attachment 757104 [details] [diff] [review]
patch

>+  #tabs-toolbar:not(:-moz-lwtheme)::before {
>+    box-shadow: 0 0 30px 30px rgb(174, 189, 204);

I'm not exactly sure what this does, but wouldn't it again introduce a blueish shadow that may or may not go well with the underlying desktop theme?

Comment 4

[Richard Marti (:Paenglab)]

Yes, but this the color whis is approved by UX team. Let's decide Mike if we should use this or a real gray. He is in close contact with the UX team and knows what is planned on FX side.

Comment 5

[rsx11m]

Ok, so the patch doesn't really address the issue for which the reporter opened this bug but merely changes the method how to achieve the effect.

Let's get some more opinions on this from the relevant people.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

I'm happy to let Mike decide this.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

(In reply to Richard Marti [:Paenglab] from comment #2)
> Mike, sorry to fill your reviewer-queue but you are the specialist for this
> with your experience on FX-Australis.

I'll do my best. :)

Comment 8

[Mike Conley (:mconley) (:⚙️)]

As usual, I've been having difficulty getting TB to build on Windows. I just got it going again, so I'll be able to review this soon.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

(In reply to Richard Marti [:Paenglab] from comment #4)
> Yes, but this the color whis is approved by UX team.

Just curious - where did you find this colour? Was it used by Firefox somewhere (I can't find it), or is it part of a spec?

Comment 10

[Richard Marti (:Paenglab)]

This comes from http://hg.mozilla.org/projects/ux/file/59e0b786a639/browser/themes/windows/browser-aero.css#l232 with changeset http://hg.mozilla.org/projects/ux/rev/4d301b6c8d27 and bug 738491.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 757104 [details] [diff] [review]
patch

Review of attachment 757104 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, ok. You have to remember that I didn't work on the Windows implementation of the curvy tabs. :)

But this looks good. Thanks Richard!

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/711a53006da4