Closed
Bug 878933
Opened 11 years ago
Closed 11 years ago
in Thunderbird message list context menu, show "Open message in new Tab" above "Open message in new Window"
Categories
(Thunderbird :: Folder and Message Lists, enhancement)
Thunderbird
Folder and Message Lists
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 24.0
People
(Reporter: aceman, Assigned: sshagarwal)
Details
Attachments
(1 file, 3 obsolete files)
4.59 KB,
patch
|
mkmelin
:
review+
sshagarwal
:
ui-review+
aceman
:
feedback+
|
Details | Diff | Splinter Review |
In the Thunderbird message list context menu, reorder the items so that "Open message in new Tab" is above "Open message in new Window". Firefox also did this change for links to promote opening in tabs more than windows.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #757546 -
Flags: ui-review?(bwinton)
Attachment #757546 -
Flags: feedback?(acelists)
Comment on attachment 757546 [details] [diff] [review] Patch Looks OK, but what about this: http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#883 ? I understand that is some other menu, but maybe it would need the treatment too? :)
Assignee | ||
Comment 3•11 years ago
|
||
Made the change for both the menus.
Attachment #757546 -
Attachment is obsolete: true
Attachment #757546 -
Flags: ui-review?(bwinton)
Attachment #757546 -
Flags: feedback?(acelists)
Attachment #757653 -
Flags: ui-review?(bwinton)
Attachment #757653 -
Flags: feedback?(acelists)
Comment on attachment 757653 [details] [diff] [review] Patch v2 Thanks.
Attachment #757653 -
Flags: feedback?(acelists) → feedback+
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 5•11 years ago
|
||
Comment on attachment 757653 [details] [diff] [review] Patch v2 I think the folderContextOpenNewWindow.label should change to "Open in New Window", but other than that (and all the changes that implies), ui-r=me. :)
Attachment #757653 -
Flags: ui-review?(bwinton) → ui-review+
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #757653 -
Attachment is obsolete: true
Attachment #763583 -
Flags: ui-review+
Attachment #763583 -
Flags: feedback?(acelists)
Comment on attachment 763583 [details] [diff] [review] Patch v3 Review of attachment 763583 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/locales/en-US/chrome/messenger/messenger.dtd @@ +588,1 @@ > <!ENTITY folderContextOpenNewWindow.accesskey "O"> I think you now also need to change the folderContextOpenNewWindow.accesskey to folderContextOpenInNewWindow.accesskey .
Attachment #763583 -
Flags: feedback?(acelists)
Assignee | ||
Comment 8•11 years ago
|
||
Sir, Made the change. Carrying over ui-r from bwinton.
Attachment #763583 -
Attachment is obsolete: true
Attachment #763748 -
Flags: ui-review+
Attachment #763748 -
Flags: feedback?(acelists)
Comment on attachment 763748 [details] [diff] [review] Patch v3 (revised) Review of attachment 763748 [details] [diff] [review]: ----------------------------------------------------------------- OK.
Attachment #763748 -
Flags: feedback?(acelists) → feedback+
Assignee | ||
Updated•11 years ago
|
Attachment #763748 -
Flags: review?(mkmelin+mozilla)
Comment 10•11 years ago
|
||
Comment on attachment 763748 [details] [diff] [review] Patch v3 (revised) Review of attachment 763748 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! r=mkmelin
Attachment #763748 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 11•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/14619b650793
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in
before you can comment on or make changes to this bug.
Description
•