Closed
Bug 878950
Opened 11 years ago
Closed 11 years ago
Add a test for HTMLImageElement and fix h/vspace reflection
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file, 1 obsolete file)
7.61 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #757543 -
Flags: review?(mounir)
Comment 1•11 years ago
|
||
Comment on attachment 757543 [details] [diff] [review] Patch v1 Review of attachment 757543 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/test/test_img_attributes_reflection.html @@ +28,5 @@ > +todo("srcset" in document.createElement("img"), "Should implement srcset") > + > +reflectString({ > + element: document.createElement("img"), > + attribute: "alt", Did you meant to have "alt" twice? @@ +31,5 @@ > + element: document.createElement("img"), > + attribute: "alt", > +}) > + > +reflectString({ Shouldn't that be reflectLimitedEnumerated? @@ +80,5 @@ > +}) > + > +reflectString({ > + element: document.createElement("img"), > + attribute: "lowsrc", That should be reflectURL according to the spec, shouldn't it? @@ +84,5 @@ > + attribute: "lowsrc", > +}) > + > +ok("x" in document.createElement("img"), "img.x is present") > +ok("y" in document.createElement("img"), "img.y is present") What are those? Also, we are missing width, height, naturalWidth and naturalHeight, right?
Attachment #757543 -
Flags: review?(mounir) → review-
Assignee | ||
Comment 2•11 years ago
|
||
I filed bugs for lowsrc (which I'm not sure we want) and crossOrigin (which I think we should change together with the other crossOrigin attributes).
Attachment #757543 -
Attachment is obsolete: true
Attachment #760128 -
Flags: review?(mounir)
Updated•11 years ago
|
Attachment #760128 -
Flags: review?(mounir) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e84d4694a553
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•