880162 - FM radio callbacks FM_RADIO_OPERATION_ENABLE when trying to disable it

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Hardware, defect)

Description

[StevenLee[:slee]]

It shouldn't callback FM_RADIO_OPERATION_ENABLE when disabling FM radio.

Comment 1

[StevenLee[:slee]]

Attachment: patch - v2

Hi Justin, 
Could you please review my patch when you have time? If you are too busy to review, please tell me.

Thanks

Comment 2

[Justin Lebar (not reading bugmail)]

>+ // The driver callback TAVARUA_EVT_RADIO_READY when we turn on and turn off it.

I'm not sure, but maybe you mean

  Don't send an update about an enabled FM radio if we're in the process of disabling the radio.  (The driver sends TAVAURA_EVT_RADIO_READY when we quickly turn the radio on and then off.)

?

Comment 3

[Justin Lebar (not reading bugmail)]

Comment on attachment 759602 [details] [diff] [review]
patch - v2

r=me with the comment sorted out.

Comment 4

[StevenLee[:slee]]

(In reply to Justin Lebar [:jlebar] from comment #2)
> I'm not sure, but maybe you mean
> 
>   Don't send an update about an enabled FM radio if we're in the process of
> disabling the radio.  (The driver sends TAVAURA_EVT_RADIO_READY when we
> quickly turn the radio on and then off.)
> 
Hi Justin,

I meant TAVAURA_EVT_RADIO_READY will always be sent when we turn off the FM radio so that we need to check additional flags.

Comment 5

[Justin Lebar (not reading bugmail)]

Oh, I see.  That's pretty weird!

If your comment said something like

  // The driver sends RADIO_READY both when we turn the radio on and when we turn the radio off.

that would be clearer to me.

Comment 6

[StevenLee[:slee]]

Attachment: patch - v3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/b3dfd511e52b

Can we get a test for this?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b3dfd511e52b