Closed
Bug 880265
Opened 11 years ago
Closed 11 years ago
Remove AudioBufferSourceNode.gain
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: ehsan.akhgari, Assigned: sankha)
References
Details
Attachments
(1 file, 1 obsolete file)
24.57 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This is probably just a matter of reverting bug 871201.
Assignee | ||
Updated•11 years ago
|
Assignee: ehsan → sankha93
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #759226 -
Flags: review?(ehsan)
Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 759226 [details] [diff] [review] patch Review of attachment 759226 [details] [diff] [review]: ----------------------------------------------------------------- Looks great! r=me with the below comments fixed. ::: content/media/webaudio/AudioBufferSourceNode.cpp @@ +85,2 @@ > default: > + NS_ERROR("Bad GainNodeEngine TimelineParameter"); Please revert this line. ::: content/media/webaudio/test/Makefile.in @@ -54,5 @@ > test_currentTime.html \ > test_delayNode.html \ > test_delayNodeSmallMaxDelay.html \ > test_delayNodeWithGain.html \ > - test_delayNodeWithGainAlternate.html \ You forgot to hg rm this file.
Attachment #759226 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #759226 -
Attachment is obsolete: true
Attachment #759885 -
Flags: review?(ehsan)
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 759885 [details] [diff] [review] final patch Review of attachment 759885 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/webaudio/AudioBufferSourceNode.cpp @@ +85,2 @@ > default: > + NS_ERROR("Bad TimelineParameter"); I meant that this line shouldn't change, but I'll fix it when landing.
Attachment #759885 -
Flags: review?(ehsan) → review+
Reporter | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7569629f5b3d
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7569629f5b3d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•