Closed Bug 880524 Opened 11 years ago Closed 11 years ago

TEST-UNEXPECTED-FAIL | tests/test-content-events.test multiple tabs | all events dispatche as expeced - [

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
All
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KWierso, Unassigned)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1025
358 bytes, text/html
evold
: review+
Details
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1026
358 bytes, text/html
evold
: review+
Details 
TEST-UNEXPECTED-FAIL | tests/test-content-events.test multiple tabs | all events dispatche as expeced - [

    "document-element-inserted -> data:text/html,first-tab",

    "DOMContentLoaded -> data:text/html,first-tab",

    "load -> data:text/html,first-tab",

    "pageshow -> data:text/html,first-tab",

    "document-element-inserted -> data:text/html,second-tab",

    "DOMContentLoaded -> data:text/html,second-tab",

    "load -> data:text/html,second-tab",

    "pageshow -> data:text/html,second-tab"

] deepEqual [

    "chrome-document-global-created -> data:application/vnd.mozilla.xul+xml;charset=utf-8,<window%20id='win'/>",

    "document-element-inserted -> data:text/html,first-tab",

    "chrome-document-global-created -> about:newtab",

    "DOMContentLoaded -> data:text/html,first-tab",

    "load -> data:text/html,first-tab",

    "pageshow -> data:text/html,first-tab",

    "document-element-inserted -> data:text/html,second-tab",

    "DOMContentLoaded -> data:text/html,second-tab",

    "load -> data:text/html,second-tab",

    "pageshow -> data:text/html,second-tab"

]

TEST-INFO | Traceback (most recent call last):

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path.tests/test-content-events.js", line 22, in handler

    resolve(tab);

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/core/promise.js", line 187, in resolve

    result.then(observer.resolve, observer.reject);

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/core/promise.js", line 45, in then

    return { then: function then(fulfill) { fulfill(value); } };

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/core/promise.js", line 120, in resolve

    deferred.resolve(onFulfill ? onFulfill(value) : value);

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/core/promise.js", line 120, in resolve

    deferred.resolve(onFulfill ? onFulfill(value) : value);

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/core/promise.js", line 187, in resolve

    result.then(observer.resolve, observer.reject);

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/core/promise.js", line 155, in then

    result.then(resolve, reject);

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/core/promise.js", line 45, in then

    return { then: function then(fulfill) { fulfill(value); } };

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/core/promise.js", line 120, in resolve

    deferred.resolve(onFulfill ? onFulfill(value) : value);

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/core/promise.js", line 120, in resolve

    deferred.resolve(onFulfill ? onFulfill(value) : value);

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path.tests/test-content-events.js", line 68, in exports["test multiple tabs"]/<

    ], "all events dispatche as expeced")

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/test/assert.js", line 164, in deepEqual

    operator: "deepEqual"

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/test/assert.js", line 89, in fail

    this._log.fail(message);

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 84, in fail

    this.console.testMessage(false, false, this.test.name, message);

  File "resource://extensions.modules.98860322-b007-4979-96d5-1f5da1d293bc-at-jetpack.commonjs.path/sdk/test/harness.js", line 523, in testMessage

    this.trace();

TEST-END | tests/test-content-events.test multiple tabs
What's the plan here? This is one of our top oranges at the moment.
Flags: needinfo?(kwierso)
Gozala, you wrote these tests, right? I'll pass Ryan's question on to you.
Flags: needinfo?(kwierso) → needinfo?(rFobic)
I have submitted a patch to fix this.
Flags: needinfo?(rFobic)
Attachment #760590 - Flags: review?(evold) → review+
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/17a69ae4ee3383c4b1260d4213014334f45a6ac2
Merge pull request #1025 from Gozala/hotfix/content-events@880524

Bug 880524 - Ignore content-document-global-created causing oranges
Attachment #761113 - Flags: review?(evold) → review+
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/de49775ed13919ff5b2e5e2617d5fd038b21e07f
Merge pull request #1026 from Gozala/hotfix/content-events@880524

Bug 880524 and Bug 879074 - Ignore *-document-global-created events that were causing frequent intermittent oranges
Status: NEW → RESOLVED
Closed: 11 years ago
Priority: -- → P1
Resolution: --- → FIXED
Commit pushed to australis at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/de49775ed13919ff5b2e5e2617d5fd038b21e07f
Merge pull request #1026 from Gozala/hotfix/content-events@880524
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: