880866 - [B2G][l10n][Calendar] Labels "From:", "To:" are not localizable

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P2)

Description

[Sarah Parsons]

Attachment: screenshot

Description:
If the user attempts to edit an alarm, the word "edit" isn't localized.

Repro Steps:
1) Updated to Unagi Build ID: 20130605070207
2) Open the Calendar App.
3) Select a day and then select the + button.
4) Create an alarm and save it.
5) Select the alarm created in the events section.

Actual:
The "edit" button in the upper right corner is not localized in Nederlands.

Expected:
"Edit" should be translated to the correct language.

Environmental Variables
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09dc1ae3b1b5
Gaia: 92a6e36957145cdb2ac8867e5cdba8ecf12308fc
Platform Version: 18.0

Notes:
Repro frequency: 100%

Comment 1

[Francesco Lodolo [:flod]]

I can confirm this issue (phone set to Italian)

https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/index.html#L408
<span data-l10n-id="edit">Edit</span>

But there's no "edit" label in the properties file
https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/locales/calendar.en-US.properties

Comment 2

[Francesco Lodolo [:flod]]

Widening the bug based on the same screenshot. Also "From:" and "To:" are not localizable (hard-coded).

https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/index.html#L432

Comment 3

[leo.bugzilla.gecko]

In triage.

Comment 4

[Leo]

Attachment: Pointer to Pull request. https://github.com/mozilla-b2g/gaia/pull/10693

Adding a pull request for localizing the "From" and "To" fields.

"Edit" field is already localized. Check here https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/locales/calendar.en-US.properties#L9

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Leo from comment #4)
> "Edit" field is already localized. Check here
> https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/locales/
> calendar.en-US.properties#L9

It was added 4 days ago, this bug is 3 weeks old ;-)
https://github.com/mozilla-b2g/gaia/commit/5de500c53d244f2bb876fef0d88e50306ba3c7e4

Apparently that string was reported in a later bug 885927 and fixed there.

Comment 6

[chris hofmann]

so is this bug now about moving the patch from 885927 to v1-train?

that would make [e-mail] the assignee.

assign back to nobody if this doesn't make sense.   we really need to get this landed quickly if there is any chance of making the zero string change deadline of june 30.

Comment 7

[Francesco Lodolo [:flod]]

(In reply to chris hofmann from comment #6)
> so is this bug now about moving the patch from 885927 to v1-train?

Nope. Bug 885927 fixed only part of this bug on master (the Edit button) and needs uplift to v1-train.

At this point "From" and "To" are still not localizable on both master and v1-train. Updating the Summary to make it more clear.

Comment 8

[James Lal [:lightsofapollo]]

in master: https://github.com/mozilla-b2g/gaia/commit/24d93dce98e7c0d7ae3b5527bf8ed22189e918ee

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 24d93dce98e7c0d7ae3b5527bf8ed22189e918ee to:
v1-train: cb642265ca4dd0ceaef47ad2c436eabb73f4f6b7

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: cb642265ca4dd0ceaef47ad2c436eabb73f4f6b7

Comment 11

[Francesco Lodolo [:flod]]

Verified on Unagi, build ID 20130701070213