Closed
Bug 880904
Opened 11 years ago
Closed 11 years ago
Add MOZ_FENNEC like MOZ_PHOENIX and MOZ_B2G
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(1 file)
I have need of defines which identify our products. We already have MOZ_PHOENIX for Desktop, and MOZ_B2G for FxOS, but nothing that I can find for just Mobile.
Attachment #760015 -
Flags: review?
Comment 1•11 years ago
|
||
I've never liked MOZ_PHOENIX. What are you trying to do that you need it to be product-specific?
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1) > I've never liked MOZ_PHOENIX. What are you trying to do that you need it to > be product-specific? WebGL conformance for a platform gates allowing requests for 'webgl' instead of 'experimental-webgl'. Conformance is established on a per-product basis. As such, I need a way to differentiate whether we allow 'webgl' request based on the product.
Comment 3•11 years ago
|
||
It does sound like you want something platform specific, not product specific.
Comment 4•11 years ago
|
||
So typically we'd have a feature switch for this, MOZ_WEBGL_NON_EXPIRIMENTAL or something. If it really is set per-product (which seems weird), you'd set it in confvars.sh. If it's actually per-platform then you'd set it somewhere in configure.in.
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4) > So typically we'd have a feature switch for this, MOZ_WEBGL_NON_EXPIRIMENTAL > or something. If it really is set per-product (which seems weird), you'd set > it in confvars.sh. If it's actually per-platform then you'd set it somewhere > in configure.in. Alright, that works too.
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•11 years ago
|
Attachment #760015 -
Flags: review?
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•