881240 - Refine title bar reveal behaviour

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

We just landed the ability to reveal the title bar by scrolling a short distance, which is great. However, the interaction could still use some refinement, so this is the follow-up bug to take care of that.

Current behaviour: Pull down a certain distance, after which point the title bar can scroll in. However, you have to keep pulling down to reveal the title bar.

Desired behaviour: Pull down a certain distance, but then quickly snap the title bar into place instead of having to pull it in by scrolling further. Our thinking is that this will make the UI feel a little more responsive than it does in the current implementation.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

For the record, B2G does the "snapping" of the title bar and I hate it. It's far too jerky and causes the page to feel jumpy while scrolling. I much prefer the current Fennec behaviour.

Comment 2

[Ian Barlow (:ibarlow)]

I should clarify what I mean by snap, because I agree that it shouldn't act like it does on B2G: the main thing is that it shouldn't push content down like it does on B2G. 

The current interaction we have on Nightly should still remain. The only real change being that once you scroll far enough to 'hook' the title bar and start pulling it down, the title bar should enter the screen at a faster rate than it does now. So while currently it scrolls at a 1:1 rate with page content, perhaps it comes in at a 2:1 rate with page content so it appears in its entirety more quickly.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

A few of us also think we should pull down the toolbar sooner. It feels too delayed.

Comment 4

[Ian Barlow (:ibarlow)]

Works for me. Let's try both at the same time.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

You can tweak this preference to change the panning distance threshold:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#438

Using "5" seems to work fine for me.

Comment 6

[Ian Barlow (:ibarlow)]

5 feels a little quick to me -- we want to account for not only quick retrieval of the bar, but also for the case of scrolling quickly down a page and then backtracking a couple of lines before showing it again. 

I got to a happy place with that at around "10" or so.

Comment 7

[Ian Barlow (:ibarlow)]

Friendly ping -- forgot about this bug and it would be nice to update that default threshold value.

Comment 8

[Lucas Rocha (:lucasr)]

Attachment: Reduce scroll threshold to reveal dynamic toolbar to 10% (r=mfinkle)

Comment 9

[Lucas Rocha (:lucasr)]

Comment on attachment 8375590 [details] [diff] [review]
Reduce scroll threshold to reveal dynamic toolbar to 10% (r=mfinkle)

Use 10% as recommended by ibarlow. I like it.

Comment 10

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/498de19fecbb

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/498de19fecbb