881325 - [MMS] [UX] Message thread. Fix spacing in the bubbles when holding a media file

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: current implementation vs suggested spacing

Top and bottom margins are too big right now, it should be 1.5rem on top and 1.5 rem bottom.
See attachment showing the bug and the recommendation.

Comment 1

[bhavana bajaj [:bajaj]]

Minor polish issue, recommend not blocking.

Comment 2

[Paul Yang [:pyang] (away)]

Try latest v1-train on unagi(6/17), can't reproduce the issue.
could you provide revision number and device name?

Comment 3

[Victoria Gerchinhoren [:vicky]]

No I see it OK also, seems to be fixed.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Victoria, 

Which version do you use?? I had traced the code found it is changed to 1.5 rem while bug 854005 patch[1] landed at May 1st, and I had checked other pages, they are also in 1.5 rem.

[1] https://github.com/mozilla-b2g/gaia/blob/0e43ae7710fa59eefb079deb52d4fab856d111ea/apps/sms/style/sms.css#L349

Comment 5

[Victoria Gerchinhoren [:vicky]]

I don't really understand your question... If it's in 1.5 rem then it is OK.

(In reply to John Hu [:johnhu] from comment #4)
> Victoria, 
> 
> Which version do you use?? I had traced the code found it is changed to 1.5
> rem while bug 854005 patch[1] landed at May 1st, and I had checked other
> pages, they are also in 1.5 rem.
> 
> [1]
> https://github.com/mozilla-b2g/gaia/blob/
> 0e43ae7710fa59eefb079deb52d4fab856d111ea/apps/sms/style/sms.css#L349