Closed Bug 881754 Opened 11 years ago Closed 11 years ago

Use bedrock /new page for locales

Categories

(www.mozilla.org :: Bedrock, defect)

Product:
www.mozilla.org
Component:
Bedrock
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pascalc, Assigned: pmac)

References

Details

(Whiteboard: [kb=1113966] )

Attachments

(2 files)

Pointer to Github pull request: https://github.com/mozilla/bedrock/pull/978
349 bytes, text/html
Details
Pointer to Github pull request: https://github.com/mozilla/bedrock/pull/1027
352 bytes, text/html
Details 
We have a set of locales for which we can show the newer design of the firefox/new page that are ready, here is the list:
bg
cs
de
el
eo
es-AR
eu
fr
gd
id
lij
nl
sk
sq
sr
sv-SE
te
tr
zh-TW

For these locales we should show the bedrock powered page, not the older php powered page.

We have a lot more locales to come, some have already translated the page but have design issues that will require CSS work), some have not all the strings translated (install instructions).

I propose that we keep this bug open so as to track all the other locales to activate instead of filing new bugs.

I am guessing that it requires setting up redirects in bedrock somewhere in https://github.com/mozilla/bedrock/blob/master/etc/httpd/

I'd be happy to update these redirects later with pull requests to add locales as they get done, but for the initial redirects, I would prefer webdev to write them.

Thanks
the lang files are on production with the ## active ## tag set
(In reply to Pascal Chevrel:pascalc from comment #1)
> the lang files are on production with the ## active ## tag set

Ok, great! So, do we just need to set up the bedrock /b/ redirects to verify localized versions of /firefox/new/?
Yeah. We'll just need to add a rule for each locale to come on board.

Pascal: Do we have the localized screenshots working as well?
Looks like we don't have localized images on this page. 

https://www.mozilla.org/b/fr/firefox/new/

Looks like maybe the instruction screenshots after you click the button aren't vital, but the big browser image when you first hit the page should probably be localized. The method for adding these images landed in bug 653876.
(In reply to Paul McLanahan [:pmac] from comment #4)
> Looks like we don't have localized images on this page. 
> 
> https://www.mozilla.org/b/fr/firefox/new/
> 
> Looks like maybe the instruction screenshots after you click the button
> aren't vital, but the big browser image when you first hit the page should
> probably be localized. The method for adding these images landed in bug
> 653876.

We've never had any screenshots on the localized download pages. 

See the old orange pages:

http://www.mozilla.org/es-ES/download/?product=firefox-21.0&os=osx&lang=pt-BR

http://www.mozilla.org/fr/download/?product=firefox-21.0&os=osx&lang=pt-BR

Also, on the features pages on localized php pages, all the screenshots are en-US:

http://www.mozilla.org/pt-BR/firefox/features/

I don't think this should be a blocker for now because we can always add the localized images later now that it is technically possible. Someone will have to install every language of the browser to get that screenshot and that could be a tedious exercise.
(In reply to Paul McLanahan [:pmac] from comment #3)
> Yeah. We'll just need to add a rule for each locale to come on board.
> 
> Pascal: Do we have the localized screenshots working as well?

No, I see that you fixed last week the longstanding bug of localized images but my department doesn't have the resources to create them, we don't even have a windows machine :)

The best being the enemy of the good, we should push without localized images for now.
(In reply to Chris More [:cmore] from comment #5)

> I don't think this should be a blocker for now because we can always add the
> localized images later now that it is technically possible. Someone will
> have to install every language of the browser to get that screenshot and
> that could be a tedious exercise.

I did that for mozilla-europe in the past, it took a lot of time (weeks) to do the 30 locales we supported. Now that we are a 900 people structure and no longer a 40 people structure, I'd advocate that this is a work to be done by professional designers :)

A couple of localizers with design affinities did provide a few screenshots on the php site though, Greek is an example: 
http://www.mozilla.org/el/firefox/features/
I agree that it shouldn't block. Just wanted to throw it out there. Hopefully it's a capacity that we can have soon. I think it'd be an especially nice touch on the /new page, but that "screen shot" has been highly stylized, so it'd probably be even more work.
Agreed that it shouldn't block.  But would also love to have localized images.  I'll start a separate thread via email to discuss with Holly, then open a design bug as appropriate.
Maybe the answer is to make the browser screenshot so stylized that it doesn't have text? :-)
(In reply to Jennifer Bertsch [:jbertsch] from comment #10)
> Maybe the answer is to make the browser screenshot so stylized that it
> doesn't have text? :-)

that would be ideal yes
2 more locales to redirect:
hr
ko

I am working on a css patch to fix Italian and Russian pages that have overlapping text per lack of space, will open a bug shortly.
Depends on: 883127
Assignee: nobody → pmac
Status: NEW → ASSIGNED
Pascal: When we move a /[locale]/firefox/new/ from php to bedrock, can we delete the page also from SVN to start the clean up of the legacy .com SVN repo?
Everyone:

I created a spreadsheet to track the progress of these pages in one central spot. There are three sheets: status sheet is dynamically generated with yes/no, and then we just need to enter in if the /b/ redirects are in place for the string complete and then we should be good to go. 

The only help that I will need with is making sure we have documented the /b/ redirects in this spreadsheet and when a locale goes live.

Pmac/pascal: Can you give you edit access? Don't modify the yes/no columns for the strings as that is updated via a copy/paste that I do with Pascal's l10n pages. I just need to document when /b/'s are set up and when we launch a locale. I want to launch only one locale to start and then verify everything is working fine.

https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0AhRMMhzzlaRtdFA1U1RRLXJNZENCX0dSdGhpelZndmc#gid=0
(In reply to Chris More [:cmore] from comment #13)
> Pascal: When we move a /[locale]/firefox/new/ from php to bedrock, can we
> delete the page also from SVN to start the clean up of the legacy .com SVN
> repo?

Yes.
(In reply to Chris More [:cmore] from comment #14)
> Pmac/pascal: Can you give you edit access? Don't modify the yes/no columns
> for the strings as that is updated via a copy/paste that I do with Pascal's
> l10n pages. I just need to document when /b/'s are set up and when we launch
> a locale. I want to launch only one locale to start and then verify
> everything is working fine.

Which locale do you want to push first?

Here is the updated list of locales ready:
bg
cs
csb
de
el
eo
es-AR
es-ES
eu
fr
gd
hr
id
it
ko
lij
mk
mr
nl
ru
sk
sq
sr
sv-SE
te
tr
uk
zh-TW
Can we please push es-ES first?
pmac, do you update and merge in https://github.com/mozilla/bedrock/pull/971 or do I make a pull request with es-ES?
What is the timeline to roll all of these out? It would be good to do a pre/post data pull on conversion rates for all of these locales. I only have conversions by GEO at the moment, which may be different than the actual locale pages.
(In reply to Gareth Cull [:garethc] from comment #19)
> What is the timeline to roll all of these out? It would be good to do a
> pre/post data pull on conversion rates for all of these locales. I only have
> conversions by GEO at the moment, which may be different than the actual
> locale pages.

Also remember that GA conversion rates will be about 15% lower than reality so if we are comparing php to python, add 15% fo the newly launched /new locale page to see how we are doing. I want to only roll out one first, evaluate with data, roll out another, evaluate, and then we can do it more quickly.
I'm happy to use es-ES as the first test once we have the timeline set and everyone is ready.
(In reply to Pascal Chevrel:pascalc from comment #18)
> pmac, do you update and merge in https://github.com/mozilla/bedrock/pull/971
> or do I make a pull request with es-ES?

pmac is on PTO this week and if we need him for this, we will have to wait to next week to launch es-ES.
I've made changed to my spreadsheet to account for the fact that there may a different number of locales for the buttons and page. It now creates a unique locale list and queries to find out if we are string complete. The "string complete" column now matches what Pascal wrote in comment 16.

https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0AhRMMhzzlaRtdFA1U1RRLXJNZENCX0dSdGhpelZndmc#gid=0
(In reply to Chris More [:cmore] from comment #22)
> (In reply to Pascal Chevrel:pascalc from comment #18)
> > pmac, do you update and merge in https://github.com/mozilla/bedrock/pull/971
> > or do I make a pull request with es-ES?
> 
> pmac is on PTO this week and if we need him for this, we will have to wait
> to next week to launch es-ES.

OK, I am going to make a Pull Request for es-ES copying the regex pmac put in his PR then.
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ca9daef4a93592fb328b59e9061595152dfc3620
Bug 881754 : redirect es-ES locale for firefox/new

https://github.com/mozilla/bedrock/commit/9d91854075c6ffb539242159ff97faede055d758
Merge pull request #978 from pascalchevrel/bug_881754_firefoxnew_SpanishRedirect

Bug 881754 : redirect es-ES locale for firefox/new
fixed on es-ES on stage https://www.allizom.org/es-ES/firefox/new/

I'm leaving this open until we push for all the locales listed in comment #16
Updated list of locales:
bg
cs
csb
cy
de
el
eo
es-AR
es-ES
eu
fr
gd
hr
id
it
ko
lij
mk
mr
nl
ro
ru
sk
sq
sr
sv-SE
te
tr
uk
zh-TW

Raymond, we'll keep this one open until we have all locales done, not just the ones in comment #16. Then we will remove the files on svn.
https://www.mozilla.org/es-ES/firefox/new/ is live! Gareth is monitoring conversions. es-ES is the 2nd biggest download page and I'm very happy that these bedrock pages are seeing the light of day for non-en-US locales. :)
Blocks: 888611
updated list of locales:
bg
cs
csb
cy
da
de
el
eo
es-AR
es-ES
et
eu
fr
gd
hr
hu
id
it
ko
lij
mk
mr
nl
pl
rm
ro
ru
sk
sq
sr
sv-SE
te
tr
uk
zh-TW

Can we push them please? Thanks
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/62464d5f130394c1aa14f7a29531563189b1bbc1
Fix bug 881754: Move firefox/new to bedrock for several locales.

Also related to bug 883127.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Tests from stage


https://www.allizom.org/bg/firefox/new/
https://www.allizom.org/cs/firefox/new/
https://www.allizom.org/csb/firefox/new/
https://www.allizom.org/en-US/firefox/new/
https://www.allizom.org/de/firefox/new/
https://www.allizom.org/el/firefox/new/
https://www.allizom.org/eo/firefox/new/
https://www.allizom.org/es-AR/firefox/new/
https://www.allizom.org/es-ES/firefox/new/
https://www.allizom.org/en-US/firefox/new/   --- redirected to en-US from et
https://www.allizom.org/fr/firefox/new/
https://www.allizom.org/gd/firefox/new/
https://www.allizom.org/en-US/firefox/new/   --- redirected to en-US from hr
https://www.allizom.org/id/firefox/new/
https://www.allizom.org/en-US/firefox/new/   --- redirected to en-US from it
https://www.allizom.org/en-US/firefox/new/
https://www.allizom.org/lij/firefox/new/
https://www.allizom.org/mk/firefox/new/
https://www.allizom.org/en-US/firefox/new/   --- redirected to en-US from mr
https://www.allizom.org/nl/firefox/new/
https://www.allizom.org/en-US/firefox/new/   --- redirected to en-US from pl
https://www.allizom.org/en-US/firefox/new/   --- redirected to en-US from rm
https://www.allizom.org/ro/firefox/new/
https://www.allizom.org/en-US/firefox/new/   --- redirected to en-US from ru
https://www.allizom.org/sk/firefox/new/
https://www.allizom.org/sq/firefox/new/
https://www.allizom.org/sr/firefox/new/
https://www.allizom.org/sv-SE/firefox/new/
https://www.allizom.org/te/firefox/new/
https://www.allizom.org/tr/firefox/new/
https://www.allizom.org/en-US/firefox/new/   --- redirected to en-US from uk
http://mozilla.com.tw/firefox/              --- redirected from zh-TW
Before we push these to prod, let's wait for Gareth to confirm the conversion rates for es-ES. Also, Laura Forrest doesn't want to go forward with /id/ right now. Please hold.
It does appear as though those lang files are not yet activated. As for zh-TW that is a redirect for everything under /firefox/. Should that stay on mozilla.org for firefox/os/?
(In reply to raymond [:retornam] from comment #32)
> Tests from stage
> https://www.allizom.org/en-US/firefox/new/   --- redirected to en-US from it

Interesting, why is this happening? CSS problems should be fixed now
https://www-dev.allizom.org/b/it/firefox/new/
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/3ca4395d218e7624ae2be8df85d9d968db062def
Revert "Bug 881754: Move firefox/new to bedrock for several locales."

Need to collect more data on conversion rates for es-ES before going
to prod with this.

This reverts commit 62464d5f130394c1aa14f7a29531563189b1bbc1.
Keeping this open for now.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Laura: We can push the /id/ of the /firefox/new/ page live? You mentioned before that you didn't want it to go live, but it is ready. We cannot do the ID SEM A/B testing without the /id/ page being live first. On stage: https://www-dev.allizom.org/b/id/firefox/new/
Flags: needinfo?(lforrest)
After further review, conversion rate has remained relatively steady (maybe down 2-3%), but there may be some slight noise right now with traffic in Spain. Segmenting  down to IE8 traffic, it showed the conversion rate remained the same.
(In reply to Gareth Cull [:garethc] from comment #39)
> After further review, conversion rate has remained relatively steady (maybe
> down 2-3%), but there may be some slight noise right now with traffic in
> Spain. Segmenting  down to IE8 traffic, it showed the conversion rate
> remained the same.

Sounds good. I think with enough traffic post-GA-fix, conversions would be about the same. We should also see an improvement with a non-es-US screenshot. I think this is good enough to know we are not damaging conversions. Let's proceed with the list from comment 30 minus /id/ as we need feedback from Laura.
Pointer to Github pull-request
Hi Laura-

We are pushing the new /new page for Indonesia and other locales on Monday, July 8.  Please contact me asap if there is a reason to not push Indonesia live.

Thx,
Jen
More locales ready:
fy-NL
is
lt
mr
my
pt-BR
Depends on: 891362
Pull Request updated.
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/3b91c7cbbf8c6bc950955dd236e57f0dd53a8ccb
Bug 881754: Move firefox/new to bedrock for several locales.

This is a reversion of a reversion. Bug is ready to move ahead.
Added the following locales today:

bg, cs, csb, cy, da, de, el, eo, es-AR, et, eu, fr, fy-NL, gd, hr, hu, id, is, it, ko, lij, lt, mk, mr, my, nl, pl, pt-BR, rm, ro, ru, sk, sq, sr, sv-SE, te, tr, uk, zh-TW
Gareth: Can you add a "yes" for the /b/ redirect column and today's date for the locales in comment 46 to this spreadsheet? https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0AhRMMhzzlaRtdFA1U1RRLXJNZENCX0dSdGhpelZndmc#gid=0

(I've updated all of the values from Pascal's dashboards)
Flags: needinfo?(lforrest)
Done.
Pascal: It looks like the fa locale is ready, but has not been pushed live. Can you confirm that it is ready?
(In reply to Chris More [:cmore] from comment #49)
> Pascal: It looks like the fa locale is ready, but has not been pushed live.
> Can you confirm that it is ready?

It is not ready, see bug 891362, the download page has visual issues with rtl locales and fa is a rtl locale
on stage

www.allizom.org/bg/firefox/new/
www.allizom.org/bg/firefox/new
www.allizom.org/cs/firefox/new
www.allizom.org/csb/firefox/new
www.allizom.org/cy/firefox/new
www.allizom.org/da/firefox/new
www.allizom.org/de/firefox/new
www.allizom.org/el/firefox/new
www.allizom.org/eo/firefox/new
www.allizom.org/es-AR/firefox/new
www.allizom.org/et/firefox/new
www.allizom.org/eu/firefox/new
www.allizom.org/fr/firefox/new
www.allizom.org/fy-NL/firefox/new
www.allizom.org/gd/firefox/new
www.allizom.org/hr/firefox/new
www.allizom.org/hu/firefox/new
www.allizom.org/id/firefox/new
www.allizom.org/is/firefox/new
www.allizom.org/it/firefox/new
www.allizom.org/ko/firefox/new
www.allizom.org/li/firefox/newj
www.allizom.org/lt/firefox/new
www.allizom.org/mk/firefox/new
www.allizom.org/mr/firefox/new
www.allizom.org/my/firefox/new
www.allizom.org/nl/firefox/new
www.allizom.org/pl/firefox/new
www.allizom.org/pt-BR/firefox/new
www.allizom.org/rm/firefox/new
www.allizom.org/ro/firefox/new
www.allizom.org/ru/firefox/new
www.allizom.org/sk/firefox/new
www.allizom.org/sq/firefox/new
www.allizom.org/sr/firefox/new
www.allizom.org/sv-SE/firefox/new
www.allizom.org/te/firefox/new
www.allizom.org/tr/firefox/new
www.allizom.org/uk/firefox/new
www.allizom.org/zh-TW/firefox/new
(In reply to raymond [:retornam] from comment #51)
> on stage
> 
> www.allizom.org/bg/firefox/new/
> www.allizom.org/bg/firefox/new
> www.allizom.org/cs/firefox/new
> www.allizom.org/csb/firefox/new
> www.allizom.org/cy/firefox/new
> www.allizom.org/da/firefox/new
> www.allizom.org/de/firefox/new
> www.allizom.org/el/firefox/new
> www.allizom.org/eo/firefox/new
> www.allizom.org/es-AR/firefox/new
> www.allizom.org/et/firefox/new
> www.allizom.org/eu/firefox/new
> www.allizom.org/fr/firefox/new
> www.allizom.org/fy-NL/firefox/new
> www.allizom.org/gd/firefox/new
> www.allizom.org/hr/firefox/new
> www.allizom.org/hu/firefox/new
> www.allizom.org/id/firefox/new
> www.allizom.org/is/firefox/new
> www.allizom.org/it/firefox/new
> www.allizom.org/ko/firefox/new
> www.allizom.org/li/firefox/newj
> www.allizom.org/lt/firefox/new
> www.allizom.org/mk/firefox/new
> www.allizom.org/mr/firefox/new
> www.allizom.org/my/firefox/new
> www.allizom.org/nl/firefox/new
> www.allizom.org/pl/firefox/new
> www.allizom.org/pt-BR/firefox/new
> www.allizom.org/rm/firefox/new
> www.allizom.org/ro/firefox/new
> www.allizom.org/ru/firefox/new
> www.allizom.org/sk/firefox/new
> www.allizom.org/sq/firefox/new
> www.allizom.org/sr/firefox/new
> www.allizom.org/sv-SE/firefox/new
> www.allizom.org/te/firefox/new
> www.allizom.org/tr/firefox/new
> www.allizom.org/uk/firefox/new
> www.allizom.org/zh-TW/firefox/new

These are all on prod now.
Just pushed to prod. Can mark this time/date in GA if need be.
GA is annotated. Thanks!
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a02a633dee4a6a5db180260134e4a197fa7e1d67
Bug 881754 - Use bedrock /new page for locales
* use a single rewrite for locales instead of multiple lines as we did for plugincheck
* redirect these additional locales :
es-CL
es-MX
ga-IE
hy-AM
ml
lv
sl

https://github.com/mozilla/bedrock/commit/83b306fad6962e7615dbc87b172cff752b48a90a
Merge pull request #1106 from pascalchevrel/Bug-881754_firefoxnew_locales_redirects

Bug 881754 - Use bedrock /new page for locales.

Merged by pmac.
When these are pushed to prod, comment in this bug so that Gareth or I can annotate GA with the locales in comment 55. thanks!
These are the locales that are ready, but have not been pushed out:

ar
ast
fa
ka
ur

Missing button strings:

ach
ak
as
be
bn-IN
bs
gl
he
hi-IN
ja
kn
ku
mai
mn
nb-NO
oc
or
pt-PT
si
ta-LK
wo

Missing page strings:

af
an
bn-BD
br
ca
ff
fi
gu-IN
kk
km
ms
nso
pa-IN
sah
son
ta
th
vi
zh-CN
(In reply to Chris More [:cmore] from comment #59)
> These are the locales that are ready, but have not been pushed out:
> Missing button strings:
> nb-NO

Request to enable nb-NO
https://github.com/mozilla/bedrock/pull/1192
Whiteboard: [kb=1113966]
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a682af83149e3c8281711cdc1a7cd82bff3217ec
Bug 881754: activate /new page for an, ast, br, fi, pt-PT

https://github.com/mozilla/bedrock/commit/2cd43bf1d8b821a4aa1748ab2df7afa9e954dcdb
Merge pull request #1219 from pascalchevrel/Bug-881754_firefoxnew_locales_redirects

Bug 881754: activate /new page for an, ast, br, fi, pt-PT
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a9ce19f43fe405a1cd1f371246a31091d1c2550a
Bug 881754: add ar & ca locales to firefox/new redirects

https://github.com/mozilla/bedrock/commit/86179edbdeacaa336d1570ba8be70a8e88361ff7
Merge pull request #1226 from pascalchevrel/Bug-881754_firefoxnew_locales_redirects

Bug 881754: add ar & ca locales to firefox/new redirects
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/cd69f9321279ab2251349ab70d10e6645bad7dc1
Bug 881754: add ka and pa-IN locales to firefox/new redirects

And fix the alphabetical order :-)

https://github.com/mozilla/bedrock/commit/604e602b4c61badbdfd2ad37f04911ca344f3bfa
Merge pull request #1233 from flodolo/paIN_ka_newpage

Bug 881754: add ka and pa-IN locales to firefox/new redirects
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/4af2ff59d8bfb99d87cbd867033ba60937b109a0
Merge pull request #1354 from pascalchevrel/Bug-892470_enable_plugincheck_redirect

Bug 881754: activate fa and hi-IN firefox/new redirects
fixed on  stage https://www.allizom.org/fa/firefox/new/
https://www.allizom.org/hi-IN/firefox/new/
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/f8f0c63c0a54fe19e607c5a6553aa57deeab6247
Bug 881754: firefox/new redirect for af and ms locales

https://github.com/mozilla/bedrock/commit/fec82a649462ee0c0bb550887a17a083da97ee9e
Merge pull request #1499 from pascalchevrel/Bug-881754-firefox_new_redirect_for_locales

Bug 881754: firefox/new redirect for af and ms locales
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d649a8836659906459f8dfd6b8f7fe9376dd2b95
Bug 881754 - Enable /new page for Vietnamese (vi)

https://github.com/mozilla/bedrock/commit/6d697880dd3af48aae6f2baffcdf871fb871f29e
Merge pull request #1909 from flodolo/vi_new

Bug 881754 - Enable /new page for Vietnamese (vi)
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/2bc684c146319c64b725b41e8f66d536e2089151
Bug 881754 - Add az, ff to /new redirect rule

https://github.com/mozilla/bedrock/commit/ba1e359ba50a75a8176aa522cd3b28b25286b819
Merge pull request #2134 from flodolo/new_az_ff

Bug 881754 - Add az, ff to /new redirect rule
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: